Skip to content

[6.1] Backport BAG failover fix. Ignore server provided failover partner. #3702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdaigle merged 7 commits into from
Oct 31, 2025
Merged

[6.1] Backport BAG failover fix. Ignore server provided failover partner. #3702

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cb6029b
Fix #3400, ignore server-provided failover partner (#3625)
mdaigle Sep 29, 2025
1573736
Adjust category level so test runs in ci.
mdaigle Oct 29, 2025
dda9c3d
Review changes.
mdaigle Oct 29, 2025
f3b7349
Clear pool to make test more reliable.
mdaigle Oct 30, 2025
376c4c6
Serialize unit tests that touch app context switches
mdaigle Oct 30, 2025
c3940ef
Are connections getting carried over in the pool somehow?
mdaigle Oct 30, 2025
2a01f50
Skip test in pipeline.
mdaigle Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Skip test in pipeline.
  • Loading branch information
@mdaigle
mdaigle committed Oct 30, 2025
commit 2a01f50fd044e7f0563c99ceac83645adc323944
11 changes: 1 addition & 10 deletions src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionFailoverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
namespace Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests
{
[Collection("SimulatedServerTests")]
[Trait("Category", "flaky")]
public class ConnectionFailoverTests
{
//TODO parameterize for transient errors
[Theory]
[Trait("Category", "flaky")]
[InlineData(40613)]
[InlineData(42108)]
[InlineData(42109)]
Expand Down Expand Up @@ -76,7 +76,6 @@ public void TransientFault_NoFailover_DoesNotClearPool(uint errorCode)
}

[Fact]
[Trait("Category", "flaky")]
public void NetworkError_TriggersFailover_ClearsPool()
{
// When connecting to a server with a configured failover partner,
Expand Down Expand Up @@ -146,7 +145,6 @@ public void NetworkError_TriggersFailover_ClearsPool()
}

[Fact]
[Trait("Category", "flaky")]
public void NetworkTimeout_ShouldFail()
{
using TdsServer failoverServer = new(
Expand Down Expand Up @@ -193,7 +191,6 @@ public void NetworkTimeout_ShouldFail()
}

[Fact]
[Trait("Category", "flaky")]
public void NetworkDelay_ShouldConnectToPrimary()
{
using TdsServer failoverServer = new(
Expand Down Expand Up @@ -246,7 +243,6 @@ public void NetworkDelay_ShouldConnectToPrimary()
}

[Fact]
[Trait("Category", "flaky")]
public void NetworkError_WithUserProvidedPartner_RetryDisabled_ShouldConnectToFailoverPartner()
{
using TdsServer failoverServer = new(
Expand Down Expand Up @@ -298,7 +294,6 @@ public void NetworkError_WithUserProvidedPartner_RetryDisabled_ShouldConnectToFa
}

[Fact]
[Trait("Category", "flaky")]
public void NetworkError_WithUserProvidedPartner_RetryEnabled_ShouldConnectToFailoverPartner()
{
using TdsServer failoverServer = new(
Expand Down Expand Up @@ -342,7 +337,6 @@ public void NetworkError_WithUserProvidedPartner_RetryEnabled_ShouldConnectToFai
}

[Theory]
[Trait("Category", "flaky")]
[InlineData(40613)]
[InlineData(42108)]
[InlineData(42109)]
Expand Down Expand Up @@ -388,7 +382,6 @@ public void TransientFault_ShouldConnectToPrimary(uint errorCode)
}

[Theory]
[Trait("Category", "flaky")]
[InlineData(40613)]
[InlineData(42108)]
[InlineData(42109)]
Expand Down Expand Up @@ -437,7 +430,6 @@ public void TransientFault_RetryDisabled_ShouldFail(uint errorCode)
}

[Theory]
[Trait("Category", "flaky")]
[InlineData(40613)]
[InlineData(42108)]
[InlineData(42109)]
Expand Down Expand Up @@ -484,7 +476,6 @@ public void TransientFault_WithUserProvidedPartner_ShouldConnectToPrimary(uint e
}

[Theory]
[Trait("Category", "flaky")]
[InlineData(40613)]
[InlineData(42108)]
[InlineData(42109)]
Expand Down
Loading