Skip to content

[Mono.Android.Export] Fix DynamicDependency to JavaArray #6105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 1 commit into from
Jul 20, 2021
Merged

[Mono.Android.Export] Fix DynamicDependency to JavaArray #6105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Mono.Android.Export] Fix DynamicDependency to JavaArray 
For awhile, we've been observing ILLink warnings:

	ILLink warning IL2036: Java.Interop.DynamicInvokeTypeInfo.ToNative(CodeExpression): Unresolved type 'Android.Runtime.JavaArray' in DynamicDependencyAttribute

The cause is a "typo" in commit 15269f6, which added the
`[DynamicDependency]` custom attributes to
`DynamicInvokeTypeInfo.ToNative()`: commit 15269f6 specified the
non-generic type `Android.Runtime.JavaArray`, which does not exist.

Fix the `[DynamicDependency]` custom attribute value to instead
mention ``Android.Runtime.JavaArray`1``, the type `JavaArray<T>`.
This should fix the IL2036 warning.
  • Loading branch information
@jonpryor
jonpryor committed Jul 20, 2021
commit a9d402f6ba0356e9cb9ffd61bf7522d704109931
2 changes: 1 addition & 1 deletion src/Mono.Android.Export/CallbackCode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ public CodeExpression FromNative (CodeExpression arg)
}

// Ignore ToNative() overload that takes generic instancing mapping. The reflected method should have nothing to do with it.
[DynamicDependency ("ToLocalJniHandle", "Android.Runtime.JavaArray", "Mono.Android")]
[DynamicDependency ("ToLocalJniHandle", "Android.Runtime.JavaArray`1", "Mono.Android")]
[DynamicDependency ("ToLocalJniHandle", "Android.Runtime.JavaCollection", "Mono.Android")]
[DynamicDependency ("ToLocalJniHandle", "Android.Runtime.JavaCollection`1", "Mono.Android")]
[DynamicDependency ("ToLocalJniHandle", "Android.Runtime.JavaDictionary", "Mono.Android")]
Expand Down