Skip to content

[Xamarin.Android.Build.Tasks] emit exported="true" for MainLauncher activities #6212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 1 commit into from
Aug 21, 2021
Merged

[Xamarin.Android.Build.Tasks] emit exported="true" for MainLauncher activities #6212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/ManifestTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,31 @@ public void CheckElementReOrdering ([Values (true, false)] bool useAapt2)
var manifestFile = Path.Combine (Root, builder.ProjectDirectory, proj.IntermediateOutputPath, "android", "AndroidManifest.xml");
XDocument doc = XDocument.Load (manifestFile);
var ns = doc.Root.GetNamespaceOfPrefix ("android");
var manifest = doc.Element ("manifest");
Assert.IsNotNull (manifest, "manifest element should not be null.");
var app = manifest.Element ("application");
Assert.IsNotNull (app, "application element should not be null.");
var manifest = GetElement (doc, "manifest");
var app = GetElement (manifest, "application");
Assert.AreEqual (0, app.ElementsAfterSelf ().Count (),
"There should be no elements after the application element");
var activity = GetElement (app, "activity");
AssertAttribute (activity, ns + "exported", "true");
var intent_filter = GetElement (activity, "intent-filter");
var action = GetElement (intent_filter, "action");
AssertAttribute (action, ns + "name", "android.intent.action.MAIN");
var category = GetElement (intent_filter, "category");
AssertAttribute (category, ns + "name", "android.intent.category.LAUNCHER");
}

static XElement GetElement (XContainer parent, XName name)
{
var e = parent.Element (name);
Assert.IsNotNull (e, $"{name} element should not be null.");
return e;
}

static void AssertAttribute (XElement parent, XName name, string expected)
{
var a = parent.Attribute (name);
Assert.IsNotNull (a, $"{name} attribute should not be null.");
Assert.AreEqual (expected, a.Value, $"{name} attribute value did not match.");
}
}

Expand Down
1 change: 1 addition & 0 deletions src/Xamarin.Android.Build.Tasks/Utilities/ManifestDocument.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,7 @@ void AddLauncherIntentElements (XElement activity)
return;

var filter = new XElement ("intent-filter");
activity.Add (new XAttribute (androidNs + "exported", "true"));
Copy link

@alihamie alihamie Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add this for all Android versions or should we only be doing it for Android 12 + ?

Copy link
Member Author

@jonathanpeppers jonathanpeppers Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not appear that //activity/@android:exported attribute has a minimum API level. Since this is a security feature, we're probably good to set this across the board?

Usually the way new attributes work in AndroidManifest.xml, is that older Android versions just ignore the values they don't know about.

Copy link

@alihamie alihamie Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh okay awesome then ! thank you

activity.AddFirst (filter);
foreach (KeyValuePair<string, string> e in LauncherIntentElements) {
if (!filter.Elements (e.Key).Any (x => ((string) x.Attribute (attName)) == e.Value))
Expand Down