Skip to content

Use new LLVM-based Xamarin.Android toolchain #6683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 3 commits into from
Mar 17, 2022
Merged

Use new LLVM-based Xamarin.Android toolchain #6683

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4cbb50
Use the new Xamarin.Android toolchain
grendello Jan 28, 2022
d165f65
Adjust paths for dynamically linked LLVM toolchain
grendello Mar 2, 2022
7d9845e
Requested changes
grendello Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Requested changes
  • Loading branch information
@grendello
grendello committed Mar 17, 2022
commit 7d9845e5a16598e39de60be393eef5afe2051f0f
7 changes: 3 additions & 4 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,11 @@ public void CheckAssemblyCounts (bool isRelease, bool aot)
}
}

// DotNet fails, see https://github.com/xamarin/xamarin-android/issues/6685
// DotNet fails, see https://github.com/dotnet/runtime/issues/65484
// Enable the commented out signature (and AOT) once the above is fixed
[Test]
[Category ("SmokeTests")]
// public void SmokeTestBuildWithSpecialCharacters ([Values (false, true)] bool forms, [Values (false, true)] bool aot)
public void SmokeTestBuildWithSpecialCharacters ([Values (false, true)] bool forms)
public void SmokeTestBuildWithSpecialCharacters ([Values (false, true)] bool forms, [Values (false /*, true*/)] bool aot)
{
var testName = "テスト";

Expand All @@ -158,7 +157,7 @@ public void SmokeTestBuildWithSpecialCharacters ([Values (false, true)] bool for
new XamarinAndroidApplicationProject ();
proj.ProjectName = testName;
proj.IsRelease = true;
proj.AotAssemblies = false; /* = true; once AOT is fixed */
proj.AotAssemblies = aot;

if (forms) {
proj.PackageReferences.Clear ();
Expand Down