[Xamarin.Android.Build.Tests] Fix some broken unit tests #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
Aug 18, 2017
| } | ||
| } | ||
|
|
||
| public string LatestTargetFrameworkVersion { |
Contributor
There was a problem hiding this comment.
This should be a method, not a property, as it's "expensive."
dellis1972
force-pushed
the
fixtests
branch
4 times, most recently
from
b38b5a3 to
5232128
Compare
The BuildMultiDexApplication and the ValidateJavaVersion tests were broken. ValidateJavaVersion required that all the tested target frameworks were built. In xamarin-android this was not the case. Only v1.0 and the latest supported one are built. So we need to modify the ResolveSdksTask to abort early if the Java Version checks fail. Similarly the BuildMultiDexApplication was using a hard coded target framework version. What we should be doing is getting it to use the latest. But we need to cacluate that at runtime so a new `LatestTargetFrameworkVersion` has been added to the Builder. This is similar to the GetSupportedRuntimes () as it caclulates the highest supported TargetFrameworkVersion.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Dec 14, 2020
Changes: dotnet/java-interop@99897b2...2f62ffd * dotnet/java-interop@2f62ffd4: [Xamarin.Android.Tools.Bytecode] @not-null androidx.annotation.NonNull (dotnet#759) * dotnet/java-interop@7c1ad51c: [java-source-utils] Properly represent unresolved types (dotnet#758) * dotnet/java-interop@c1bc5c83: [java-source-utils] Better support orphaned Javadocs (dotnet#757) * dotnet/java-interop@0cb8e2d3: [Xamarin.Android.Tools.ApiXmlAdjuster] Use Dictionaries for perf (dotnet#756) * dotnet/java-interop@99f89905: [build] Fix for MSBuild 16.8 (dotnet#755)
jonpryor
added a commit
that referenced
this pull request
Dec 15, 2020
Changes: dotnet/java-interop@99897b2...2f62ffd * dotnet/java-interop@2f62ffd4: [Xamarin.Android.Tools.Bytecode] @not-null androidx.annotation.NonNull (#759) * dotnet/java-interop@7c1ad51c: [java-source-utils] Properly represent unresolved types (#758) * dotnet/java-interop@c1bc5c83: [java-source-utils] Better support orphaned Javadocs (#757) * dotnet/java-interop@0cb8e2d3: [Xamarin.Android.Tools.ApiXmlAdjuster] Use Dictionaries for perf (#756) * dotnet/java-interop@99f89905: [build] Fix for MSBuild 16.8 (#755)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BuildMultiDexApplication and the ValidateJavaVersion tests
were broken. ValidateJavaVersion required that all the tested target
frameworks were built. In xamarin-android this was not the case.
Only v1.0 and the latest supported one are built.
So we need to modify the ResolveSdksTask to abort early if the
Java Version checks fail.
Similarly the BuildMultiDexApplication was using a hard coded
target framework version. What we should be doing is getting
it to use the latest. But we need to cacluate that at runtime
so a new
LatestTargetFrameworkVersionhas been added to theBuilder. This is similar to the GetSupportedRuntimes () as it
caclulates the highest supported TargetFrameworkVersion.