Skip to content

Bump to xamarin/java.interop/main@1adb7964 #8339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 4 commits into from
Nov 7, 2023
Merged

Bump to xamarin/java.interop/main@1adb7964 #8339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f202e3b
Bump to xamarin/java.interop/main@1adb7964
jonpryor Sep 15, 2023
57337ed
Make AndroidEmitLegacyInterfaceInvokers private
jonpryor Oct 26, 2023
4301223
Bump to xamarin/java.interop/main@38c8a827e78ffe9c80ad2313a9e0e0d4f82…
jonpryor Nov 3, 2023
9127ae1
Merge remote-tracking branch 'origin/main' into jonp-try-ji-1145
jonpryor Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make AndroidEmitLegacyInterfaceInvokers private 
As per discussion.
  • Loading branch information
@jonpryor
jonpryor committed Oct 26, 2023
commit 57337eda1f0d6b8533b3e3a98eb015b037f8ac5c
9 changes: 0 additions & 9 deletions Documentation/guides/building-apps/build-properties.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,15 +430,6 @@ documentation on [D8 and R8][d8-r8].
[dex]: https://source.android.com/devices/tech/dalvik/dalvik-bytecode
[d8-r8]: https://github.com/xamarin/xamarin-android/blob/main/Documentation/guides/D8andR8.md

## AndroidEmitLegacyInterfaceInvokers

A boolean property that determines whether or not "legacy" interface invokers are generated.
This should only be done if using the new optimizerd interface invoker infrastructure results
in build failures.

The default value is `False`, and more optimized interface invokers are generated.

Added in .NET 9.0.

## AndroidEnableDesugar

Expand Down
2 changes: 1 addition & 1 deletion ...Xamarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Bindings.Core.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ It is shared between "legacy" binding projects and .NET 5 projects.
ToolPath="$(_BindingsToolsLocation)"
ToolExe="$(BindingsGeneratorToolExe)"
LangVersion="$(LangVersion)"
EmitLegacyInterfaceInvokers="$(AndroidEmitLegacyInterfaceInvokers)"
EmitLegacyInterfaceInvokers="$(_AndroidEmitLegacyInterfaceInvokers)"
EnableBindingStaticAndDefaultInterfaceMethods="$(AndroidBoundInterfacesContainStaticAndDefaultInterfaceMethods)"
EnableBindingNestedInterfaceTypes="$(AndroidBoundInterfacesContainTypes)"
EnableBindingInterfaceConstants="$(AndroidBoundInterfacesContainConstants)"
Expand Down
2 changes: 1 addition & 1 deletion ...Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<AndroidBoundInterfacesContainStaticAndDefaultInterfaceMethods Condition=" '$(AndroidBoundInterfacesContainStaticAndDefaultInterfaceMethods)' == '' ">true</AndroidBoundInterfacesContainStaticAndDefaultInterfaceMethods>
<AndroidBoundInterfacesContainTypes Condition=" '$(AndroidBoundInterfacesContainTypes)' == '' ">true</AndroidBoundInterfacesContainTypes>
<AndroidBoundInterfacesContainConstants Condition=" '$(AndroidBoundInterfacesContainConstants)' == '' ">true</AndroidBoundInterfacesContainConstants>
<AndroidEmitLegacyInterfaceInvokers Condition=" '$(AndroidEmitLegacyInterfaceInvokers)' == '' ">false</AndroidEmitLegacyInterfaceInvokers>
<_AndroidEmitLegacyInterfaceInvokers Condition=" '$(AndroidEmitLegacyInterfaceInvokers)' == '' ">false</_AndroidEmitLegacyInterfaceInvokers>
<AndroidEnableObsoleteOverrideInheritance Condition=" '$(AndroidEnableObsoleteOverrideInheritance)' == '' ">true</AndroidEnableObsoleteOverrideInheritance>
<AndroidEnableRestrictToAttributes Condition=" '$(AndroidEnableRestrictToAttributes)' == '' ">obsolete</AndroidEnableRestrictToAttributes>

Expand Down