Skip to content

Fix AndroidPackagingOptionsExclude so it can be overridden in the csproj #8459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 8 commits into from
Nov 20, 2023
Merged

Fix AndroidPackagingOptionsExclude so it can be overridden in the csproj #8459

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f249070
Initial Commit
dellis1972 Oct 25, 2023
575cd41
Add Tests
dellis1972 Oct 25, 2023
bee8e2d
Updated test
dellis1972 Oct 25, 2023
ca58877
Add Docs
dellis1972 Oct 26, 2023
055f155
Change docs
dellis1972 Nov 1, 2023
221dbea
update docs
dellis1972 Nov 2, 2023
a93b220
update docs
dellis1972 Nov 2, 2023
faf297e
update docs
dellis1972 Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated test
  • Loading branch information
@dellis1972
dellis1972 committed Nov 7, 2023
commit bee8e2d9aaa823c7dfc2ee1c43673a55a1e2dce7
2 changes: 1 addition & 1 deletion src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ public void CheckIncludedFilesArePresent ()
var apk = Path.Combine (Root, b.ProjectDirectory,
proj.OutputPath, $"{proj.PackageName}-Signed.apk");
using (var zip = ZipHelper.OpenZip (apk)) {
Assert.IsTrue (zip.ContainsEntry ("kotlin/reflect/reflect.kotlin_builtins"), "reflect.kotlin_builtins should have been ignored.");
Assert.IsTrue (zip.ContainsEntry ("kotlin/reflect/reflect.kotlin_builtins"), "reflect.kotlin_builtins should have been included.");
}
}
}
Expand Down