Skip to content

Netstandard Support #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 5 commits into from
Nov 27, 2017
Merged

Netstandard Support #846

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a3cabc
[Xamarin.Android.Build.Tasks] Netstandard Support
dellis1972 Oct 17, 2017
de93b44
ff
dellis1972 Nov 23, 2017
795eb96
Fix expected assemblies
dellis1972 Nov 23, 2017
8e2b54d
Backup process log
dellis1972 Nov 23, 2017
334cbca
Removed redundant File.Delete
dellis1972 Nov 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Backup process log
  • Loading branch information
@dellis1972
dellis1972 committed Nov 23, 2017
commit 8e2b54d8d5f4066cd564979cbb000209cbe99489
2 changes: 2 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Common/Builder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,8 @@ protected bool BuildInternal (string projectOrSolution, string target, string []

if (nativeCrashDetected) {
Console.WriteLine ($"Native crash detected! Running the build for {projectOrSolution} again.");
File.Move(processLog, processLog + ".bak");
File.Delete(processLog);
Copy link
Contributor

@jonpryor jonpryor Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this actually delete anything? The previous line ensures that processLog will no longer exist, unless the directory that processLog is in doesn't allow renaming...in which case, what are the odds that the File.Delete() will work either?

continue;
} else {
break;
Expand Down