[Mono.Android] Remove Mono_UnhandledException lookup #8618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can simplify `JNIEnv.PropagateUncaughtException` by removing the fallback case that would attempt to look for `System.Diagnostics.Debugger.Mono_UnhandledException`. In .NET the `MonodroidRuntime::monodroid_debugger_unhandled_exception` function will always be defined, and `Mono_UnhandledException` appears to no longer exist in .NET. This simplification should also appease our latest set of API scan results that were complaining about missing documentation for `Mono_UnhandledException`.
Member
Author
|
I've updated the apkdesc files due to the size reduction in Mono.Android.Runtime.dll:
|
pjcollins
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
jonathanpeppers
approved these changes
Jan 9, 2024
grendello
added a commit
that referenced
this pull request
Jan 10, 2024
* main: Bump to xamarin/monodroid@66a65e3b3e (#8604) [Mono.Android] Remove Mono_UnhandledException lookup (#8618)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can simplify
JNIEnv.PropagateUncaughtExceptionby removing thefallback case that would attempt to look for
System.Diagnostics.Debugger.Mono_UnhandledException. In .NET theMonodroidRuntime::monodroid_debugger_unhandled_exceptionfunction willalways be defined, and
Mono_UnhandledExceptionappears to no longerexist in .NET. This simplification should also appease our latest set
of API scan results that were complaining about missing documentation
for
Mono_UnhandledException.