Skip to content

[xamarin-android-tools] import $(LibZipSharpVersion) value #8738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 1 commit into from
Feb 21, 2024
Merged

[xamarin-android-tools] import $(LibZipSharpVersion) value #8738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[xamarin-android-tools] import $(LibZipSharpVersion) value 
Somewhere in the dotnet/maui repo, it encountered the error:

    XARLP7028
    System.IO.FileNotFoundException: Could not load file or assembly 'libZipSharp, Version=3.0.0.0, Culture=neutral, PublicKeyToken=276db85bc4e20efc' or one of its dependencies. The system cannot find the file specified.File name: 'libZipSharp, Version=3.0.0.0, Culture=neutral, PublicKeyToken=276db85bc4e20efc'   at Xamarin.Android.Tasks.ResolveLibraryProjectImports.Extract(IDictionary`2 jars, ICollection`1 resolvedResourceDirectories, ICollection`1 resolvedAssetDirectories, ICollection`1 resolvedEnvironments, ICollection`1 proguardConfigFiles)   at Xamarin.Android.Tasks.ResolveLibraryProjectImports.RunTask()   at Microsoft.Android.Build.Tasks.AndroidTask.Execute() in /Users/runner/work/1/s/xamarin-android/external/xamarin-android-tools/src/Microsoft.Android.Build.BaseTasks/AndroidTask.cs:line 25WRN: Assembly binding logging is turned OFF.To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.Note: There is some performance penalty associated with assembly bind failure logging.To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].
    Graphics (Graphics\src\Graphics)
    C:\repos\dotnet\maui\bin\dotnet\packs\Microsoft.Android.Sdk.Windows\34.99.0-preview.2.171\tools\Xamarin.Android.EmbeddedResource.targets

(don't have a link)

If I download our build from main, I see that
`Microsoft.Android.Build.BaseTasks.dll` references the 3.0.0.0 version
of libZipSharp, while the other MSBuild task assemblies reference the
newer one.

We override `$(LibZipSharpVersion)` in `Directory.Build.props`, but
this value doesn't make it inside the `external/xamarin-android-tools`
submodule. Import `Directory.Build.props` from the submodule's
`*.override.props` file.
  • Loading branch information
@jonathanpeppers
jonathanpeppers committed Feb 20, 2024
commit f6dabe3d0aa3550b14e63807c70a8b386dc17a4f
4 changes: 4 additions & 0 deletions external/xamarin-android-tools.override.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<Project>
<!-- Import $(LibZipSharpVersion) -->
<Import Project="..\Directory.Build.props" />
</Project>