Skip to content

[trimming] remove $(_AggressiveAttributeTrimming) by default #9062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dellis1972 merged 2 commits into from
Jun 28, 2024
+82 −83
Merged

[trimming] remove $(_AggressiveAttributeTrimming) by default #9062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d7808a
[trimming] remove `$(_AggressiveAttributeTrimming)` by default
jonathanpeppers Jun 28, 2024
1516210
`.apkdesc` files
jonathanpeppers Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@
<StartupHookSupport Condition="'$(StartupHookSupport)' == ''">false</StartupHookSupport>
<UseNativeHttpHandler Condition=" $(AndroidHttpClientHandlerType.Contains ('System.Net.Http.SocketsHttpHandler')) And '$(UseNativeHttpHandler)' == '' ">false</UseNativeHttpHandler>
<UseNativeHttpHandler Condition="'$(UseNativeHttpHandler)' == ''">true</UseNativeHttpHandler>
<_AggressiveAttributeTrimming Condition="'$(_AggressiveAttributeTrimming)' == ''">true</_AggressiveAttributeTrimming>
<NullabilityInfoContextSupport Condition="'$(NullabilityInfoContextSupport)' == ''">false</NullabilityInfoContextSupport>
Copy link
Member

@sbomer sbomer Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanpeppers note that NullabilityInfoContextSupport was removed in dotnet/runtime#103970.

<BuiltInComInteropSupport Condition="'$(BuiltInComInteropSupport)' == ''">false</BuiltInComInteropSupport>
<JsonSerializerIsReflectionEnabledByDefault Condition="'$(JsonSerializerIsReflectionEnabledByDefault)' == '' and '$(TrimMode)' == 'partial'">true</JsonSerializerIsReflectionEnabledByDefault>
Expand Down
30 changes: 15 additions & 15 deletions ...ild.Tasks/Tests/Xamarin.ProjectTools/Resources/Base/BuildReleaseArm64SimpleDotNet.apkdesc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,43 +8,43 @@
"Size": 22488
},
"lib/arm64-v8a/lib__Microsoft.Android.Resource.Designer.dll.so": {
"Size": 1027
"Size": 1114
},
"lib/arm64-v8a/lib_Java.Interop.dll.so": {
"Size": 64653
"Size": 66243
},
"lib/arm64-v8a/lib_Mono.Android.dll.so": {
"Size": 92659
"Size": 94712
},
"lib/arm64-v8a/lib_Mono.Android.Runtime.dll.so": {
"Size": 5394
"Size": 5320
},
"lib/arm64-v8a/lib_System.Console.dll.so": {
"Size": 6512
"Size": 7226
},
"lib/arm64-v8a/lib_System.Linq.dll.so": {
"Size": 8489
"Size": 9294
},
"lib/arm64-v8a/lib_System.Private.CoreLib.dll.so": {
"Size": 575506
"Size": 596083
},
"lib/arm64-v8a/lib_System.Runtime.dll.so": {
"Size": 2554
"Size": 2969
},
"lib/arm64-v8a/lib_System.Runtime.InteropServices.dll.so": {
"Size": 3999
"Size": 4475
},
"lib/arm64-v8a/lib_UnnamedProject.dll.so": {
"Size": 2934
"Size": 2932
},
"lib/arm64-v8a/libarc.bin.so": {
"Size": 1586
"Size": 1546
},
"lib/arm64-v8a/libmono-component-marshal-ilgen.so": {
"Size": 87432
},
"lib/arm64-v8a/libmonodroid.so": {
"Size": 492104
"Size": 492344
},
"lib/arm64-v8a/libmonosgen-2.0.so": {
"Size": 3163208
Expand All @@ -62,10 +62,10 @@
"Size": 159544
},
"lib/arm64-v8a/libxamarin-app.so": {
"Size": 17984
"Size": 17960
},
"META-INF/BNDLTOOL.RSA": {
"Size": 1223
"Size": 1221
},
"META-INF/BNDLTOOL.SF": {
"Size": 3266
Expand Down Expand Up @@ -98,5 +98,5 @@
"Size": 1904
}
},
"PackageSize": 2693653
"PackageSize": 2714133
Copy link
Member Author

@jonathanpeppers jonathanpeppers Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a Xamarin.Forms (legacy) app is about 77kb bigger and hello world android 20kb bigger.

That seems reasonable if there is concern of something breaking from this setting.

}
134 changes: 67 additions & 67 deletions ...ild.Tasks/Tests/Xamarin.ProjectTools/Resources/Base/BuildReleaseArm64XFormsDotNet.apkdesc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,193 +29,193 @@
"Size": 2396
},
"lib/arm64-v8a/lib__Microsoft.Android.Resource.Designer.dll.so": {
"Size": 2279
"Size": 2363
},
"lib/arm64-v8a/lib_FormsViewGroup.dll.so": {
"Size": 8330
},
"lib/arm64-v8a/lib_Java.Interop.dll.so": {
"Size": 72814
"Size": 74373
},
"lib/arm64-v8a/lib_Mono.Android.dll.so": {
"Size": 459203
"Size": 470377
},
"lib/arm64-v8a/lib_Mono.Android.Runtime.dll.so": {
"Size": 5392
"Size": 5320
},
"lib/arm64-v8a/lib_mscorlib.dll.so": {
"Size": 4000
"Size": 4360
},
"lib/arm64-v8a/lib_netstandard.dll.so": {
"Size": 5634
"Size": 6003
},
"lib/arm64-v8a/lib_System.Collections.Concurrent.dll.so": {
"Size": 11901
"Size": 12458
},
"lib/arm64-v8a/lib_System.Collections.dll.so": {
"Size": 15960
"Size": 16436
},
"lib/arm64-v8a/lib_System.Collections.NonGeneric.dll.so": {
"Size": 7964
"Size": 8448
},
"lib/arm64-v8a/lib_System.Collections.Specialized.dll.so": {
"Size": 5896
"Size": 6629
},
"lib/arm64-v8a/lib_System.ComponentModel.dll.so": {
"Size": 1943
"Size": 2428
},
"lib/arm64-v8a/lib_System.ComponentModel.Primitives.dll.so": {
"Size": 3632
"Size": 4094
},
"lib/arm64-v8a/lib_System.ComponentModel.TypeConverter.dll.so": {
"Size": 22409
"Size": 24729
},
"lib/arm64-v8a/lib_System.Console.dll.so": {
"Size": 6542
"Size": 7264
},
"lib/arm64-v8a/lib_System.Core.dll.so": {
"Size": 1977
"Size": 2376
},
"lib/arm64-v8a/lib_System.Diagnostics.DiagnosticSource.dll.so": {
"Size": 9493
"Size": 10315
},
"lib/arm64-v8a/lib_System.Diagnostics.TraceSource.dll.so": {
"Size": 7009
"Size": 7486
},
"lib/arm64-v8a/lib_System.dll.so": {
"Size": 2371
"Size": 2779
},
"lib/arm64-v8a/lib_System.Drawing.dll.so": {
"Size": 1942
"Size": 2359
},
"lib/arm64-v8a/lib_System.Drawing.Primitives.dll.so": {
"Size": 11940
"Size": 12474
},
"lib/arm64-v8a/lib_System.IO.Compression.Brotli.dll.so": {
"Size": 11627
"Size": 12315
},
"lib/arm64-v8a/lib_System.IO.Compression.dll.so": {
"Size": 15753
"Size": 16663
},
"lib/arm64-v8a/lib_System.IO.IsolatedStorage.dll.so": {
"Size": 10293
"Size": 11008
},
"lib/arm64-v8a/lib_System.Linq.dll.so": {
"Size": 20088
"Size": 21038
},
"lib/arm64-v8a/lib_System.Linq.Expressions.dll.so": {
"Size": 164366
"Size": 167929
},
"lib/arm64-v8a/lib_System.Net.Http.dll.so": {
"Size": 68333
"Size": 69565
},
"lib/arm64-v8a/lib_System.Net.Primitives.dll.so": {
"Size": 22619
"Size": 23728
},
"lib/arm64-v8a/lib_System.Net.Requests.dll.so": {
"Size": 3597
"Size": 4368
},
"lib/arm64-v8a/lib_System.ObjectModel.dll.so": {
"Size": 9090
"Size": 9745
},
"lib/arm64-v8a/lib_System.Private.CoreLib.dll.so": {
"Size": 879691
"Size": 907085
},
"lib/arm64-v8a/lib_System.Private.DataContractSerialization.dll.so": {
"Size": 192540
"Size": 198923
},
"lib/arm64-v8a/lib_System.Private.Uri.dll.so": {
"Size": 43081
"Size": 44799
},
"lib/arm64-v8a/lib_System.Private.Xml.dll.so": {
"Size": 215206
"Size": 217533
},
"lib/arm64-v8a/lib_System.Private.Xml.Linq.dll.so": {
"Size": 17138
"Size": 18124
},
"lib/arm64-v8a/lib_System.Runtime.dll.so": {
"Size": 2708
"Size": 3129
},
"lib/arm64-v8a/lib_System.Runtime.InteropServices.dll.so": {
"Size": 3999
"Size": 4475
},
"lib/arm64-v8a/lib_System.Runtime.Serialization.dll.so": {
"Size": 1867
"Size": 2281
},
"lib/arm64-v8a/lib_System.Runtime.Serialization.Formatters.dll.so": {
"Size": 2531
"Size": 3165
},
"lib/arm64-v8a/lib_System.Runtime.Serialization.Primitives.dll.so": {
"Size": 3761
"Size": 4226
},
"lib/arm64-v8a/lib_System.Security.Cryptography.dll.so": {
"Size": 8770
"Size": 10032
},
"lib/arm64-v8a/lib_System.Text.RegularExpressions.dll.so": {
"Size": 161067
"Size": 163519
},
"lib/arm64-v8a/lib_System.Xml.dll.so": {
"Size": 1763
"Size": 2182
},
"lib/arm64-v8a/lib_System.Xml.Linq.dll.so": {
"Size": 1781
"Size": 2193
},
"lib/arm64-v8a/lib_UnnamedProject.dll.so": {
"Size": 5007
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.Activity.dll.so": {
"Size": 16323
"Size": 17023
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.AppCompat.AppCompatResources.dll.so": {
"Size": 6438
"Size": 6979
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.AppCompat.dll.so": {
"Size": 138385
"Size": 139892
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.CardView.dll.so": {
"Size": 6959
"Size": 7469
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.CoordinatorLayout.dll.so": {
"Size": 18150
"Size": 18822
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.Core.dll.so": {
"Size": 127206
"Size": 129133
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.CursorAdapter.dll.so": {
"Size": 8978
"Size": 9607
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.DrawerLayout.dll.so": {
"Size": 15504
"Size": 16100
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.Fragment.dll.so": {
"Size": 51881
"Size": 53241
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.Legacy.Support.Core.UI.dll.so": {
"Size": 6233
"Size": 6806
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.Lifecycle.Common.dll.so": {
"Size": 6890
"Size": 7450
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.Lifecycle.LiveData.Core.dll.so": {
"Size": 6733
"Size": 7279
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.Lifecycle.ViewModel.dll.so": {
"Size": 7002
"Size": 7592
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.Loader.dll.so": {
"Size": 13063
"Size": 13717
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.RecyclerView.dll.so": {
"Size": 93874
"Size": 95160
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.SavedState.dll.so": {
"Size": 5107
"Size": 5628
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.SwipeRefreshLayout.dll.so": {
"Size": 14226
"Size": 14856
},
"lib/arm64-v8a/lib_Xamarin.AndroidX.ViewPager.dll.so": {
"Size": 19353
"Size": 20040
},
"lib/arm64-v8a/lib_Xamarin.Forms.Core.dll.so": {
"Size": 563905
Expand All @@ -230,16 +230,16 @@
"Size": 63542
},
"lib/arm64-v8a/lib_Xamarin.Google.Android.Material.dll.so": {
"Size": 66529
"Size": 67669
},
"lib/arm64-v8a/libarc.bin.so": {
"Size": 1586
"Size": 1546
},
"lib/arm64-v8a/libmono-component-marshal-ilgen.so": {
"Size": 87432
},
"lib/arm64-v8a/libmonodroid.so": {
"Size": 492104
"Size": 492344
},
"lib/arm64-v8a/libmonosgen-2.0.so": {
"Size": 3163208
Expand All @@ -257,7 +257,7 @@
"Size": 159544
},
"lib/arm64-v8a/libxamarin-app.so": {
"Size": 348544
"Size": 348520
},
"META-INF/androidx.activity_activity.version": {
"Size": 6
Expand Down Expand Up @@ -410,7 +410,7 @@
"Size": 6
},
"META-INF/BNDLTOOL.RSA": {
"Size": 1221
"Size": 1223
},
"META-INF/BNDLTOOL.SF": {
"Size": 98341
Expand Down Expand Up @@ -2480,5 +2480,5 @@
"Size": 812848
}
},
"PackageSize": 10267731
"PackageSize": 10345555
}