Port https://github.com/dotnet/arcade/pull/10451 changes to rel/6.0 #11412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riarenas
approved these changes
Oct 25, 2022
garath
approved these changes
Oct 25, 2022
Member
Author
|
As there is no functionality in this change exercised by the Helix tests that failed, I am bypassing policy and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check:
Arcade Test run of these changes: https://dnceng.visualstudio.com/internal/_build/results?buildId=2029580&view=logs&j=7d9eef18-6720-5c1f-4d30-89d7b76728e9
Arcade-Services test run of these changes: https://dnceng.visualstudio.com/internal/_build/results?buildId=2029572&view=logs&j=7d9eef18-6720-5c1f-4d30-89d7b76728e9&t=66df1a84-4ac1-5ba1-6998-e011cc992fec