Unset platform vars in toolchain file for cmake3.25 #11672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
force-pushed
the
feature/cmake-3.25
branch
from
440a6ee to
63b9db2
Compare
akoeplinger
approved these changes
Nov 18, 2022
Member
|
Merging since dotnet/runtime#78534 was merged. |
Member
|
/backport to release/7.0 |
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/arcade/actions/runs/3498263895 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/arcade/actions/runs/3498264639 |
This was referenced Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cmake 3.25, the toolchain file is called with context containing
LINUXvariable set. This causes problem for non-Linux platform. Fix is to unset platform variables which we use in the toolchain file.Issue: dotnet/runtime#78528