Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Feb 26, 2023

  • Add linux-musl-x86 with its default
  • Move default versions selection in its own block to simplify the logic
  • compiler-rt-static package was merged into compiler-rt starting with alpine 3.16 alpinelinux/aports@f378b64. Handle this for newer versions.
  • Fix a bug around pattern matching which wasn't performing s390x or ppc64le; caught by shellcheck:

    SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally.

cc @janvorli

janvorli
janvorli previously approved these changes Feb 27, 2023
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@am11
Copy link
Member Author

am11 commented Mar 1, 2023

@janvorli, I don't have the write access, can you please merge this?

@janvorli janvorli merged commit 089b4a3 into dotnet:main Mar 1, 2023
@am11 am11 deleted the patch-6 branch March 1, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants