Skip to content

Add an opt-in target to flag .NETStandard1.x dependencies #13219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmitche merged 3 commits into from
Apr 20, 2023
Merged

Add an opt-in target to flag .NETStandard1.x dependencies #13219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcd7975
Add an opt-in target to flag .NETStandard1.x dependencies
ViktorHofer Apr 20, 2023
e38bb37
Update TargetFrameworkFilters.BeforeCommonTargets.targets
ViktorHofer Apr 20, 2023
96cc60e
Update ArcadeSdk.md
ViktorHofer Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Documentation/ArcadeSdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,6 +1041,8 @@ If set to `true` calls to GetResourceString receive a default resource string va
#### `GenerateResxSourceOmitGetResourceString` (bool)
If set to `true` the GetResourceString method is not included in the generated class and must be specified in a separate source file.

#### `FlagNetStandard1XDependencies` (bool)
If set to `true` the `FlagNetStandard1xDependencies` target validates that the dependency graph doesn't contain any netstandard1.x packages.

<!-- Begin Generated Content: Doc Feedback -->
<sub>Was this helpful? [![Yes](https://helix.dot.net/f/ip/5?p=Documentation%5CArcadeSdk.md)](https://helix.dot.net/f/p/5?p=Documentation%5CArcadeSdk.md) [![No](https://helix.dot.net/f/in)](https://helix.dot.net/f/n/5?p=Documentation%5CArcadeSdk.md)</sub>
Expand Down
63 changes: 63 additions & 0 deletions src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,68 @@
<!-- If nothing left to build, exclude it! -->
<ExcludeFromBuild Condition="'$(_FilteredTargetFrameworks)' == ''">true</ExcludeFromBuild>
</PropertyGroup>

<!-- Opt-in target to verify that a project doesn't bring in the .NET Standard 1.x dependency graph
(usually transitively) via old dependencies. -->
<Target Name="FlagNetStandard1xDependencies"
Condition="'$(FlagNetStandard1XDependencies)' == 'true'"
AfterTargets="ResolvePackageAssets">
<ItemGroup>
<NetStandard1xPackage Include="
Microsoft.Win32.Primitives;
System.AppContext;
System.Collections;
System.Collections.Concurrent;
System.Console;
System.Diagnostics.Debug;
System.Diagnostics.Tools;
System.Diagnostics.Tracing;
System.Globalization;
System.Globalization.Calendars;
System.IO;
System.IO.Compression;
System.IO.Compression.ZipFile;
System.IO.FileSystem;
System.IO.FileSystem.Primitives;
System.Linq;
System.Linq.Expressions;
System.Net.Http;
System.Net.Primitives;
System.Net.Sockets;
System.ObjectModel;
System.Reflection;
System.Reflection.Extensions;
System.Reflection.Primitives;
System.Resources.ResourceManager;
System.Runtime;
System.Runtime.Extensions;
System.Runtime.Handles;
System.Runtime.InteropServices;
System.Runtime.InteropServices.RuntimeInformation;
System.Runtime.Numerics;
System.Security.Cryptography.Algorithms;
System.Security.Cryptography.Encoding;
System.Security.Cryptography.Primitives;
System.Security.Cryptography.X509Certificates;
System.Text.Encoding;
System.Text.Encoding.Extensions;
System.Text.RegularExpressions;
System.Threading;
System.Threading.Tasks;
System.Threading.Timer;
System.Xml.ReaderWriter;
System.Xml.XDocument" />
</ItemGroup>

<ItemGroup>
<NonFoundNetStandard1xPackage Include="@(PackageDependencies)"
Exclude="@(NetStandard1xPackage)" />
<FoundNetStandard1xPackage Include="@(PackageDependencies)"
Exclude="@(NonFoundNetStandard1xPackage)" />
</ItemGroup>

<Error Text="The following .NET Standard 1.x packages are referenced and must be removed: %0D%0A- @(FoundNetStandard1xPackage, '%0D%0A- ')%0D%0AConsult the project.assets.json files to find the parent dependencies."
Condition="'@(FoundNetStandard1xPackage)' != ''" />
</Target>

</Project>