Skip to content

Remove non needed xml tags #13292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ViktorHofer merged 1 commit into from
Apr 25, 2023
Merged

Remove non needed xml tags #13292

ViktorHofer merged 1 commit into from
Apr 25, 2023

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 25, 2023 •
edited
Loading

Those tags aren't required by msbuild anymore: dotnet/corefx#35686 (comment)

We removed them from corefx (now dotnet/runtime) 4 years ago and didn't encounter any issues with tooling. Our samples don't include them either.

To double check:

@ViktorHofer ViktorHofer requested a review from mmitche April 25, 2023 16:34
@ViktorHofer ViktorHofer merged commit 7b204a2 into dotnet:main Apr 25, 2023
@ViktorHofer ViktorHofer deleted the RemoveXmlTags branch April 25, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmitche mmitche mmitche approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ViktorHofer @mmitche