Migrate to Microsoft.Identity.Client for creating aka.ms links

[MilenaHristova]

dotnet/arcade-services#2631

Migrating from Microsoft.IdentityModel.Clients.ActiveDirectory to Microsoft.Identity.Client for authenticating with Azure Active Directory and creating aka.ms links, because Microsoft.IdentityModel.Clients.ActiveDirectory is deprecated.
Adding a feature switch so that the change can get to the Stage-DotNet-Test pipeline without breaking arcade and we can make sure publishing works with the new library.
Once it's validated by running the staging pipeline we'll remove the switch and leave the code that uses the new library. #13318

To double check:

• The right tests are in and and the right validation has happened. Guidance: https://github.com/dotnet/arcade/tree/main/Documentation/Validation

[premun]

@MilenaHristova if this is a new feature that should eventually replace the current way and this is a feature switch you should ideally:

• Desribe this in the PR
• Create an issue that says something like "switch to the new library in full once we know it works"
• Add TODOs in the code to say it's temporary, link the issue and say it will be removed as it's a feature switch only

[premun]

Ah, I guess this was forgotten behind. You could log this on a lower level and you'd still find it in the binlog just not the regular log

[ViktorHofer]

We define all package versions in Versions.props. Please move it there into the "externals" section.

[MilenaHristova]

Moved it in the next pr #13476

[ViktorHofer]

Great change. Note that symboluploader in the dotnet-symboluploader also uses Microsoft.IdentityModel.Clients.ActiveDirectory and should be updated as well.

[andriipatsula]

@MilenaHristova do we need to make changes in the dotnet-release repository?

[tkapin]

Great change. Note that symboluploader in the dotnet-symboluploader also uses Microsoft.IdentityModel.Clients.ActiveDirectory and should be updated as well.

@hoyosjs - you seem to be the last one contributing to dotnet-symuploader repo, do you know who's would be best to take care of this?

[hoyosjs]

The diagnostics teams helps maintain it - the AAD option hasn't been deeply supported lately. All our usage is around is PATs. We do know the migration is necessary - and at the same time we are trying to deprecate the tool in favor of symbol. cc: @dotnet/dotnet-diag