Skip to content

Conversation

@epananth
Copy link
Member

To double check:

Issue -> #13326

@garath
Copy link
Member

garath commented Apr 28, 2023

It looks like these came up after changes in #13210. @ViktorHofer FYI, in case you want to review this.

@epananth epananth requested a review from ViktorHofer April 28, 2023 00:28
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as request changes so that I can first take a look. Thanks for letting me know.

@premun
Copy link
Member

premun commented Apr 28, 2023

cc @MilenaHristova

@ViktorHofer
Copy link
Member

I submitted #13341 which is the better fix as it avoids these dependencies all-together. There's a remaining set of packages that are problematic, which I will work on in the next days:

We can enable Arcade's FlagNetStandard1xDependencies switch when those dependencies are updated and consumed. That will then guard against any future netstandard1.x dependencies being consumed.

@epananth
Copy link
Member Author

Thanks @ViktorHofer, going to close this PR.

@epananth epananth closed this Apr 28, 2023
@epananth epananth deleted the cg-april-errors branch April 28, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants