Skip to content

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Jan 30, 2025

This is a replacement for PublishFlatContainer, with the intention of extending this to include PDBArtifacts, so that we can remove the separate handling of these prior to build promotion. Kind has 2 current types, and is valid on artifact data: Package and Blob. If Kind is set, it overrides the PublishFlatContainer setting for the given artifact. Otherwise the existing defaults/behavior are used.

To double check:

This is a replacement for PublishFlatContainer, with the intention of extending this to include PDBArtifacts, so that we can remove the separate handling of these prior to build promotion.
Kind has 2 current types, and is valid on artifact data: Package and Blob. If Kind is set, it overrides the PublishFlatContainer setting for the given artifact. Otherwise the existing defaults/behavior are used.
@mmitche mmitche requested review from a team and ViktorHofer January 30, 2025 23:42
@mmitche
Copy link
Member Author

mmitche commented Jan 30, 2025

@ViktorHofer Needs local verification.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also want ItemsToPushToBlobFeed items that are manually added by repos to respect that new metadata. The best place to do that would be here:

<ItemGroup>
<ItemsToPushToBlobFeed>
<!-- Default artifact visibility is External -->
<Visibility Condition="'%(ItemsToPushToBlobFeed.Visibility)' == ''">$([MSBuild]::ValueOrDefault('$(DefaultArtifactVisibility)', 'External'))</Visibility>
<!-- Default to IsShipping=true -->
<IsShipping Condition="'%(ItemsToPushToBlobFeed.IsShipping)' == ''">true</IsShipping>
</ItemsToPushToBlobFeed>
</ItemGroup>

@mmitche mmitche merged commit fe76d5d into dotnet:main Feb 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants