Revert "Add dotnet-install scripts that understand the "productVersio… #6492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n.txt" file (dotnet#6051)" This reverts commit 88ce535 except for spelling errors.
2 tasks
mmitche
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support was added to understand a file found in the same path as .NET Core SDKs/ Runtimes named "productVersion.txt".
When found, this allows version redirection, allowing a non-stable build to have assets that are installed like they are stably-versioned. At the time, these scripts were added to Arcade's eng/common folder and Arcade was made to (by default) use these copies of the scripts.
Since dotnet/install-scripts#76 has been merged and rolled out to the public locations, a local copy of these scripts is no longer desirable.
Customer Impact
If we don't do this, breaking changes and/or improvements made in the public https://dot.net/v1/dotnet-install.* scripts would not be adopted by the release/5.0 branch.
Regression
No : this was always the plan once the scripts were in the public location.
Risk
Low: Aside from some logging improvements made as part of the PR, the public scripts are nearly identical to the ones being deleted. The same change has already been promoted in the master branch, as well.
Workarounds
We could choose to do nothing, but if a breaking change is ever made within the scripts we'd have to copy these changes into the release/5.0 branch
(This reverts commit 88ce535 except for spelling errors.)