Skip to content

add terminfo-db to FreeBSD package requirements #7588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 5 commits into from
Jul 30, 2021
Merged

add terminfo-db to FreeBSD package requirements #7588

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
099f8f8
add terminfo-db to FreeBSD package requirements
Thefrank Jul 4, 2021
c99d3fc
Merge branch 'dotnet:main' into freebsd-crossrootfs
Thefrank Jul 16, 2021
51c137b
fix typo, bump FreeBSD12, remove lttng-ust from it
Thefrank Jul 29, 2021
71ec321
lttng-ust needs to stay
Thefrank Jul 29, 2021
6e8077a
add FreeBSD13, add support for FreeBSD ABI
Thefrank Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add terminfo-db to FreeBSD package requirements 
* runtime can use terminfo under FreeBSD but only with this additional package
* from feedback: dotnet/runtime#55152 (comment)
  • Loading branch information
@Thefrank
Thefrank authored Jul 4, 2021
commit 099f8f8dd661b083eb055a3c72f4440033421b09
1 change: 1 addition & 0 deletions eng/common/cross/build-rootfs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ __FreeBSDPackages+=" icu"
__FreeBSDPackages+=" libinotify"
__FreeBSDPackages+=" lttng-ust"
__FreeBSDPackages+=" krb5"
__FreeBSDPackages+=" terminfo-db"
Copy link
Member

@wfurt wfurt Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this also work with freebsd11 ? This script is sucked in by the docker build process and I'm wondering if there is chance we break it.

If so, one option would be to first remove
https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/9458314c28f5c051299fc24f3cb602a113cfcf49/manifest.json#L553-L564

Copy link
Contributor Author

@Thefrank Thefrank Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, terminfo-db is found in the pkg repo for FreeBSD 11, 12, and 13.

https://www.freshports.org/misc/terminfo-db/


__IllumosPackages="icu-64.2nb2"
__IllumosPackages+=" mit-krb5-1.16.2nb4"
Expand Down