Skip to content

Conversation

@MattGal
Copy link
Member

@MattGal MattGal commented Aug 31, 2021

… and set some values in eng/common Job template. Edit: after PR feedbacks the settings went into common build entry points where other nuget settings already existed

To double check:

…Y, and set some values in eng/common Job template.
…pport and will not receive security updates in the future."
@MattGal MattGal force-pushed the nuget-restore-improvements branch from b145c81 to fd58003 Compare August 31, 2021 17:28
@MattGal MattGal merged commit ca8ebd3 into dotnet:main Aug 31, 2021
@riarenas
Copy link
Contributor

Just making sure the right folks are aware that this means we're taking another unsigned unreleased SDK throughout the stack.

premun added a commit that referenced this pull request Sep 1, 2021
Comment on lines +932 to +935
<NETCoreApp31RIDs Condition="'@(NETCoreApp31RIDs)' == ''" Include="@(NETCoreApp30RIDs)" />
<DefaultValidateFramework Include="netcoreapp3.1">
<RuntimeIDs>@(NETCoreApp31RIDs)</RuntimeIDs>
</DefaultValidateFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why did you touch this as part of your PR? FYI we plan to delete this library with #7783.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why did you touch this as part of your PR? FYI we plan to delete this library with #7783.

Mostly it just came up in the grep, I asked @mmitche if it should have a 3.1 entry and he said it ought to. Will be happy to see this one and Tasks.Feed go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants