Handle the lack of a ScmRepositoryUrl when batch updating SourceRoot items. #7852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Sep 8, 2021
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
LGTM but I also collaborated with Matt offline so 🧂.
michellemcdaniel
approved these changes
Sep 8, 2021
Contributor
|
Thanks for the quick fix Matt! |
MattGal
added a commit
to MattGal/arcade
that referenced
this pull request
Sep 8, 2021
Address dotnet#7850 - handle the lack of a ScmRepositoryUrl when batch updating (dotnet#7852)
1 task
MattGal
added a commit
that referenced
this pull request
Sep 8, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7850 . Big thanks to @rainersigwald for the MSBuild guidance.
To double check: