Port to release/6.0: Fix lld support #7884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have found that when I've made a change to use the lld linker in July, I've missed to push part of the change that was supposed to go to Arcade. Without this change, the lld enabling flag is not used and we end up using the default linker.
jkoritzinsky
approved these changes
Sep 10, 2021
Member
Author
|
Is there any process to follow before merging into the arcade release/6.0 branch? |
Member
|
I'm not sure who the person is to ping to get this merged. @mmitche @jeffschwMSFT any ideas? |
Member
|
I defer to @mmitche for this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that when I've made a change to use the lld linker in July,
I've missed to push part of the change that was supposed to go to Arcade.
Without this change, the lld enabling flag is not used and we end up using
the default linker.