Also set NUGET enhanced environment variables in MSBuild-Core() #7916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in MSBuild-Core()
jakubstilec
approved these changes
Sep 20, 2021
Member
Author
|
I verified that the variables are now in the ToolSetRestore.binlog file. |
jakubstilec
pushed a commit
to jakubstilec/arcade
that referenced
this pull request
Sep 21, 2021
…t in MSBuild-Core() (dotnet#7916)
jakubstilec
pushed a commit
that referenced
this pull request
Sep 22, 2021
…etting so we can also do it in MSBuild-Core() (#7916) (#7921) Co-authored-by: Matt Galbraith <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/core-eng/issues/13691 continuation; the problem can happen during toolset restore, where we don't have the variables set. Also turns on logging that the set occurred for future log reading.
To double check: