Change owner of uploaded files to helix-runner in Apple XHarness workloads #7986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubstilec
approved these changes
Oct 4, 2021
Member
Author
MattGal
reviewed
Oct 11, 2021
| fi | ||
|
|
||
| # The simulator logs comming from the sudo-spawned Simulator.app are not readable/deletable by the helix uploader | ||
| sudo chown -R helix-runner "$output_directory" |
Member
There was a problem hiding this comment.
helix-runner should be $(whoami). The helix user's name is arbitrary and could vary in the future, but you know that the current work item is that users.
Member
Author
There was a problem hiding this comment.
Yeah, I was thinking about that, to store it in a variable first and then use it here. I just want to see it work first though.
Will note it down and change
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested directories were not readable and files were not uploaded
Discovered in dotnet/runtime#58870 (comment)
Files belong to root as they are created during the
launchctl asuserworkaround