add property to disable building the manifest file #8143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
reviewed
Nov 5, 2021
src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets
Outdated
Show resolved
Hide resolved
ericstj
approved these changes
Nov 5, 2021
Contributor
Author
|
@mmitche do we need to wait for the release in order to merge this ? |
Member
|
No....merge as you wish. Is this required for 6.0.1? |
Member
|
Yes it is required for 6.0.1. |
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to pin the platform manifest for the ref packs, hence adding a property to disable creation of new platform manifest file during servicing.