Port "ignore nonexistent queue" functionality to release/5.0 #8155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onally ignore when a queue does not exist. Port of dotnet#8069 (bbb4187)
6 tasks
mmitche
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check:
Description
Context: https://github.com/dotnet/core-eng/issues/14572
Port of #8069 (bbb4187). Allows users who want to to ignore non-existent Helix queues, so we don't have to keep every queue that we've ever had in existence in our yaml files forever.
Customer Impact
This change allows customers to decide whether their build should break (and thus require attention) when sending to and end-of-life-d queue, or just print a warning.
Without this change, any old queue that has been removed (e.g. OSX.1012.Amd64) will cause failure once the changes to do this are merged.
Regression
No
Risk
Low; only two queues we'd remove (osx.1012.amd64, redhat.6.amd64) have been used in the past 30 days, from 3.1 release branches, and these can be left alone until addressed.
Workarounds
User will have to work around this by removing dead queues manually without this setting available in the Arcade SDK.