Add support for dotnetbuilds-published dotnet cli packages #8162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGal
approved these changes
Nov 9, 2021
mmitche
reviewed
Nov 9, 2021
| $installParameters.FeedCredential = $decodedString | ||
| } | ||
| $dotnetBuilds = $installParameters.Clone() | ||
| $dotnetbuilds.AzureFeed = "https://dotnetbuilds.azureedge.net/public" |
Member
There was a problem hiding this comment.
I didn't think we had a CDN for this account, is this right?
mmitche
reviewed
Nov 9, 2021
Member
mmitche
left a comment
mmitche
left a comment
There was a problem hiding this comment.
Couple questions, but looks generally okay.
| Write-PipelineTelemetryError -Category 'InitializeToolset' -Message "Failed to install dotnet from custom location '$runtimeSourceFeed'." | ||
| ExitWithExitCode 1 | ||
| } | ||
| if ($runtimeSourceFeed) { |
Member
There was a problem hiding this comment.
Are we going to need a variation for dotnetbuilds/internal? Or would we be planning on replacing the existing usage of runtimesourcefeed as dotnetclimsrc in the repos with dotnetbuilds/internal instead?
Member
Author
There was a problem hiding this comment.
Yea, we should just use dotnetbuilds/internal in place of dotnetclimsrc in our current workflow
mmitche
approved these changes
Nov 10, 2021
Closed
2 tasks
alexperovich
added a commit
to alexperovich/arcade
that referenced
this pull request
Nov 16, 2021
alexperovich
added a commit
that referenced
this pull request
Nov 16, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for installing dotnet cli packages that were published to dotnetbuilds to both the helix sdk FindDotNetCliPackage task, and the build scripts.