Skip to content

Allow override of UpgradeCode seed #8177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NikolaMilosavljevic merged 1 commit into from
Nov 13, 2021
Merged

Allow override of UpgradeCode seed #8177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/targets/windows/wix.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,12 @@
<Target Name="GetUpgradeCode"
DependsOnTargets="GetWixBuildConfiguration"
Condition="'$(UpgradeCode)' == ''">
<GenerateGuidFromName Name="$(OutInstallerFile)">

<PropertyGroup>
<MsiUpgradeCodeSeed Condition="'$(MsiUpgradeCodeSeed)' == ''">$(OutInstallerFile)</MsiUpgradeCodeSeed>
</PropertyGroup>

<GenerateGuidFromName Name="$(MsiUpgradeCodeSeed)">
Copy link
Member

@ericstj ericstj Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like an installer could already specify the UpgradeCode property directly, which might be easier.

Copy link
Member Author

@NikolaMilosavljevic NikolaMilosavljevic Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's what I eventually settled on: dotnet/runtime#61606

<Output TaskParameter="GeneratedGuid" PropertyName="UpgradeCode" />
</GenerateGuidFromName>
</Target>
Expand Down