Fix regression in CoreClrConfigurationDetection #8222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 16988fc the refactoring added `IsGCStress` and used it in the `IsStressTest` property. However the `GetEnvironmentVariableValue("GCStress") != string.Empty` is always true since `GetEnvironmentVariableValue` will return the string "0" if the env variable isn't set. This in turn caused `StressModeApplies` to return false for `RuntimeTestModes.RegularRun` which made the `SkipOnCoreClr` attribute a no-op in regular runs.
premun
approved these changes
Nov 26, 2021
jkoritzinsky
approved these changes
Nov 26, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 16988fc the refactoring added
IsGCStressand used it in theIsStressTestproperty.However the
GetEnvironmentVariableValue("GCStress") != string.Emptyis always true sinceGetEnvironmentVariableValuewill return the string "0" if the env variable isn't set.This in turn caused
StressModeAppliesto return false forRuntimeTestModes.RegularRunwhich made theSkipOnCoreClrattribute a no-op in regular runs. Discovered while looking at failures in dotnet/runtime#61668./cc @jkoritzinsky