Revert "Fix warnings on Helix EOL queues" #8452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatalas
approved these changes
Feb 10, 2022
Member
|
@premun those are warnings, not errors, and people who don't want them yet could choose to not update their helix SDK instead of reverting this in arcade main. Please contact me at your earliest convenience. |
MattGal
reviewed
Feb 10, 2022
Member
Author
|
@MattGal I don't think people (dotnet/runtime in this case) cannot "choose to not update their Helix SDK". There are other changes in arcade that some teams are waiting for. I misunderstood your change, I thought you are bumping warnings to errors, not the other way. We will fix it in runtime's repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8426
This is because we started getting unavoidable errors in dotnet/runtime#65068 while we have no new queue to migrate
Windows.10.Amd64.Server19H1.ES.Opento.It is also not the way to go imho. This change means that
dotnet/runtimewill start to break randomly when one of the EOLs is 3 weeks away.