Skip to content

Allow trimming out incompatible ProjectReferences #8459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorHofer merged 7 commits into from
Feb 12, 2022
Merged

Allow trimming out incompatible ProjectReferences #8459

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b5280a1
Allow trimming out incompatible ProjectReferences
ViktorHofer Feb 11, 2022
7298f69
Update Microsoft.DotNet.Build.Tasks.TargetFramework.targets
ViktorHofer Feb 11, 2022
b3ac1f6
Update ChooseBestP2PTargetFrameworkTask.cs
ViktorHofer Feb 11, 2022
d6b118d
Update Microsoft.DotNet.Build.Tasks.TargetFramework.targets
ViktorHofer Feb 11, 2022
5f368f1
Update ChooseBestP2PTargetFrameworkTask.cs
ViktorHofer Feb 11, 2022
77aaf65
Update ChooseBestP2PTargetFrameworkTask.cs
ViktorHofer Feb 11, 2022
2839ba9
Update Microsoft.DotNet.Build.Tasks.TargetFramework.targets
ViktorHofer Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update ChooseBestP2PTargetFrameworkTask.cs
  • Loading branch information
@ViktorHofer
ViktorHofer authored Feb 11, 2022
commit 5f368f121ed437052ba5314100c9aab720485c7a
4 changes: 2 additions & 2 deletions src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/ChooseBestP2PTargetFrameworkTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class ChooseBestP2PTargetFrameworkTask : BuildTask
[Required]
public string TargetFramework { get; set; }

public bool TrimIncompatibleProjectReferencesWithoutRaisingAnError { get; set; }
public bool TrimIncompatibleProjectReferences { get; set; }

[Output]
public ITaskItem[] AnnotatedProjectReferencesWithSetTargetFramework { get; set; }
Expand Down Expand Up @@ -48,7 +48,7 @@ public override bool Execute()
string bestTargetFramework = targetFrameworkResolver.GetBestSupportedTargetFramework(targetFrameworks, referringTargetFramework);
if (bestTargetFramework == null)
{
if (TrimIncompatibleProjectReferencesWithoutRaisingAnError)
if (TrimIncompatibleProjectReferences)
{
continue;
}
Expand Down