Reduce imports in generate-locproject.ps1 #9887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no need for `import-module` nor all of tools.ps1
Contributor
Author
|
This PR applies the suggestion I mentioned in FR channel. I tested the changes locally using dotnet/aspnetcore and dotnet/spa-templates and everything worked fine. Also tested w/ |
riarenas
approved these changes
Jul 6, 2022
Contributor
riarenas
left a comment
riarenas
left a comment
There was a problem hiding this comment.
Looks fine to me, but I would wait for @jonfortescue to chime in.
jonfortescue
approved these changes
Jul 6, 2022
Contributor
jonfortescue
left a comment
jonfortescue
left a comment
There was a problem hiding this comment.
Perfect, thanks for doing this, Doug!
This was referenced Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import-modulenor all of tools.ps1