Skip to content

Add ContainerBuildOptions support to ResourceContainerImageBuilder for customizing dotnet publish #10074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
captainsafia merged 17 commits into from
Jul 10, 2025
Merged

Add ContainerBuildOptions support to ResourceContainerImageBuilder for customizing dotnet publish #10074

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e59eb66
Initial plan
Copilot Jun 26, 2025
a455b56
Implement ContainerBuildOptions for ResourceContainerImageBuilder
Copilot Jun 26, 2025
7d99db0
Update container runtimes to support ContainerBuildOptions and remove…
Copilot Jun 26, 2025
0844e4d
Fix argument quoting, use docker buildx, and restore missing else case
Copilot Jul 3, 2025
9864489
Use enum for TargetPlatform
captainsafia Jul 7, 2025
fcbd217
Update compat suppressions file
captainsafia Jul 7, 2025
9125a8f
Address all feedback comments: Remove DockerTar enum, fix MSBuild map…
Copilot Jul 8, 2025
e00837e
Clean up logs and format
captainsafia Jul 8, 2025
bbb0e73
Add tests and fix OCI docker
captainsafia Jul 8, 2025
447c25f
Update compat suppressions file
captainsafia Jul 8, 2025
096bc8e
Remove hard-coded x64 platform in DockerComposePublishingContext
Copilot Jul 8, 2025
115e593
Add WindowsArm64 platform support to ContainerTargetPlatform enum
Copilot Jul 8, 2025
f0c0fee
Address code review feedback: make extension class internal, use get/…
Copilot Jul 8, 2025
cd81d67
Feedback and test update
captainsafia Jul 9, 2025
ad2c9f3
Fix output path formatting
captainsafia Jul 9, 2025
7f3ca1e
Use default format for Docker compose
captainsafia Jul 9, 2025
6fff8f4
Fix output path names
captainsafia Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove hard-coded x64 platform in DockerComposePublishingContext 
Co-authored-by: eerhardt <[email protected]>
  • Loading branch information
@eerhardt
Copilot and eerhardt committed Jul 8, 2025
commit 096bc8e7d8f617f540f4522fcef26344051e36c8
3 changes: 1 addition & 2 deletions src/Aspire.Hosting.Docker/DockerComposePublishingContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,7 @@ private async Task WriteDockerComposeOutputAsync(DistributedApplicationModel mod
// Build container images for the services that require it
if (containerImagesToBuild.Count > 0)
{
var options = new ContainerBuildOptions { TargetPlatform = ContainerTargetPlatform.LinuxAmd64 };
await ImageBuilder.BuildImagesAsync(containerImagesToBuild, options: options, cancellationToken).ConfigureAwait(false);
await ImageBuilder.BuildImagesAsync(containerImagesToBuild, options: null, cancellationToken).ConfigureAwait(false);
}

var step = await activityReporter.CreateStepAsync(
Expand Down
Loading