Skip to content

Added support for prompting for parameter values in run mode #10235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidfowl merged 12 commits into from
Jul 3, 2025
Merged

Added support for prompting for parameter values in run mode #10235

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
88fc925
Added support for prompting for parameter values
davidfowl Jul 3, 2025
985ca1c
Refactor HandleUnresolvedParametersAsync to use List for inputs inste…
davidfowl Jul 3, 2025
42001b5
Add unit tests for ParameterProcessor functionality
davidfowl Jul 3, 2025
c7f95fc
Refactor HandleUnresolvedParametersAsync for improved testing and int…
davidfowl Jul 3, 2025
03e5755
Refactor HandleUnresolvedParametersAsync test to use array for parame…
davidfowl Jul 3, 2025
4adeb7a
Refactor HandleUnresolvedParametersAsync tests to improve async handl…
davidfowl Jul 3, 2025
cfdc386
Refactor HandleUnresolvedParametersAsync test to enhance interaction …
davidfowl Jul 3, 2025
a44dfae
Refactor exception handling in environment variable tests to use Miss…
davidfowl Jul 3, 2025
8954f93
Add MissingParameterValueException for handling missing parameter values
davidfowl Jul 3, 2025
a6d7c4c
PR feedback
davidfowl Jul 3, 2025
19e90b6
Fix capitalization in interaction titles for unresolved parameters
davidfowl Jul 3, 2025
9ad2e0d
Update HandleUnresolvedParametersAsync to set Required property to fa…
davidfowl Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor exception handling in environment variable tests to use Miss… 
…ingParameterValueException
  • Loading branch information
@davidfowl
davidfowl committed Jul 3, 2025
commit a44dfae2cd738e2bcf50bc70be4d27e6e37dbfcc
2 changes: 1 addition & 1 deletion tests/Aspire.Hosting.Tests/WithEnvironmentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public async Task EnvironmentCallbackThrowsWhenParameterValueMissingInDcpMode()
var projectA = builder.AddProject<ProjectA>("projectA")
.WithEnvironment("MY_PARAMETER", parameter);

var exception = await Assert.ThrowsAsync<DistributedApplicationException>(async () => await EnvironmentVariableEvaluator.GetEnvironmentVariablesAsync(
var exception = await Assert.ThrowsAsync<MissingParameterValueException>(async () => await EnvironmentVariableEvaluator.GetEnvironmentVariablesAsync(
projectA.Resource,
DistributedApplicationOperation.Run,
TestServiceProvider.Instance
Expand Down
2 changes: 1 addition & 1 deletion tests/Aspire.Hosting.Tests/WithReferenceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public async Task ParameterAsConnectionStringResourceThrowsWhenConnectionStringS
.WithReference(missingResource);

// Call environment variable callbacks.
var exception = await Assert.ThrowsAsync<DistributedApplicationException>(async () =>
var exception = await Assert.ThrowsAsync<MissingParameterValueException>(async () =>
{
var config = await EnvironmentVariableEvaluator.GetEnvironmentVariablesAsync(projectB.Resource, DistributedApplicationOperation.Run, TestServiceProvider.Instance);
}).DefaultTimeout();
Expand Down
Loading