re-review

src/Aspire.Hosting/ApplicationModel/ContainerExecutableResource.cs

@@ -6,6 +6,9 @@
 
 namespace Aspire.Hosting.ApplicationModel;
 
+/// <summary>
+/// Executable resource that runs in a container.
+/// </summary>
 internal class ContainerExecutableResource(string name, ContainerResource containerResource, string command, string? workingDirectory)
     : Resource(name), IResourceWithEnvironment, IResourceWithArgs, IResourceWithEndpoints, IResourceWithWaitSupport
 {
@@ -19,8 +22,14 @@ internal class ContainerExecutableResource(string name, ContainerResource contai
     /// </summary>
     public string? WorkingDirectory { get; } = workingDirectory;
 
+    /// <summary>
+    /// Args of the command to run in the container.
+    /// </summary>
     public ICollection<string>? Args { get; init; }
 
+    /// <summary>
+    /// Target container resource that this executable runs in.
+    /// </summary>
     public ContainerResource? TargetContainerResource { get; } = containerResource ?? throw new ArgumentNullException(nameof(containerResource));
 
     private static string ThrowIfNullOrEmpty([NotNull] string? argument, [CallerArgumentExpression(nameof(argument))] string? paramName = null)

src/Aspire.Hosting/Dcp/DcpExecutor.cs

@@ -1119,7 +1119,6 @@ await _executorEvents.PublishAsync(new OnResourceChangedContext(
 
                         try
                         {
-                            // await CreateExecutableAsync(er, resourceLogger, cancellationToken).ConfigureAwait(false);
                             await createResourceFunc(er, resourceLogger, cancellationToken).ConfigureAwait(false);
                         }
                         catch (FailedToApplyEnvironmentException)

src/Aspire.Hosting/Dcp/ResourceSnapshotBuilder.cs

@@ -114,10 +114,8 @@ public CustomResourceSnapshot ToSnapshot(ContainerExec executable, CustomResourc
             State = state,
             ExitCode = executable.Status?.ExitCode,
             Properties = previous.Properties.SetResourcePropertyRange([
-                // new(KnownProperties.Executable.Path, executable.Spec.ExecutablePath),
                 new(KnownProperties.Executable.WorkDir, executable.Spec.WorkingDirectory),
                 new(KnownProperties.Executable.Args, executable.Status?.EffectiveArgs ?? []) { IsSensitive = true },
-                // new(KnownProperties.Executable.Pid, executable.Status?.ProcessId),
                 new(KnownProperties.Resource.AppArgs, launchArguments?.Args) { IsSensitive = launchArguments?.IsSensitive ?? false },
                 new(KnownProperties.Resource.AppArgsSensitivity, launchArguments?.ArgsAreSensitive) { IsSensitive = launchArguments?.IsSensitive ?? false },
             ]),

src/Aspire.Hosting/Exec/ExecResourceManager.cs

@@ -105,7 +105,7 @@ public async IAsyncEnumerable<CommandOutput> StreamExecResourceLogs([EnumeratorC
 
             // hack: https://github.com/dotnet/aspire/issues/10245
             // workarounds the race-condition between streaming all logs from the resource, and resource completion
-            await Task.Delay(2000, CancellationToken.None).ConfigureAwait(false);
+            await Task.Delay(1000, CancellationToken.None).ConfigureAwait(false);
 
             _resourceLoggerService.Complete(dcpExecResourceName); // complete stops the `WatchAsync` async-foreach below
         }, cancellationToken);

tests/Shared/DistributedApplicationTestingBuilderExtensions.cs

@@ -21,7 +21,6 @@ public static IDistributedApplicationTestingBuilder WithTestAndResourceLogging(t
     {
         builder.Services.AddXunitLogging(testOutputHelper);
         builder.Services.AddLogging(builder => builder.AddFilter("Aspire.Hosting", LogLevel.Trace));
-        builder.Services.AddLogging(builder => builder.AddFilter("Aspire.Hosting.Dcp", LogLevel.Trace));
         return builder;
     }