Skip to content

[release/13.0] Improve flaky dashboard integration test #12549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joperezr merged 4 commits into from
Oct 31, 2025
Merged

[release/13.0] Improve flaky dashboard integration test #12549

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9631ff0
Improve flaky dashboard integration test
JamesNK Oct 31, 2025
75724a3
Fix extra tests
JamesNK Oct 31, 2025
a32d384
Apply suggestion from @Copilot
JamesNK Oct 31, 2025
402fddf
Apply suggestion from @Copilot
JamesNK Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix extra tests
  • Loading branch information
@JamesNK
JamesNK authored and github-actions committed Oct 31, 2025
commit 75724a321f973e67837461f052a62c4c21037df6
7 changes: 7 additions & 0 deletions tests/Aspire.Dashboard.Tests/Integration/FrontendBrowserTokenAuthTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,13 @@ public async Task LogOutput_NoToken_GeneratedTokenLogged()
Assert.NotEqual(0, uri.Port);
},
w =>
{
Assert.Equal("MCP listening on: {McpEndpointUri}", GetValue(w.State, "{OriginalFormat}"));

var uri = new Uri((string)GetValue(w.State, "McpEndpointUri")!);
Assert.NotEqual(0, uri.Port);
},
w =>
{
Assert.Equal("OTLP server is unsecured. Untrusted apps can send telemetry to the dashboard. For more information, visit https://go.microsoft.com/fwlink/?linkid=2267030", GetValue(w.State, "{OriginalFormat}"));
Assert.Equal(LogLevel.Warning, w.LogLevel);
Expand Down
7 changes: 7 additions & 0 deletions tests/Aspire.Dashboard.Tests/Integration/StartupTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,13 @@ public async Task LogOutput_DynamicPort_PortResolvedInLogs()
Assert.NotEqual(0, uri.Port);
},
w =>
{
Assert.Equal("MCP listening on: {McpEndpointUri}", GetValue(w.State, "{OriginalFormat}"));

var uri = new Uri((string)GetValue(w.State, "McpEndpointUri")!);
Assert.NotEqual(0, uri.Port);
},
w =>
{
Assert.Equal("OTLP server is unsecured. Untrusted apps can send telemetry to the dashboard. For more information, visit https://go.microsoft.com/fwlink/?linkid=2267030", GetValue(w.State, "{OriginalFormat}"));
Assert.Equal(LogLevel.Warning, w.LogLevel);
Expand Down