Skip to content

[release/13.0] Allow HostUrl to remap both address and port #12552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danegsta merged 15 commits into from
Nov 4, 2025
Merged

[release/13.0] Allow HostUrl to remap both address and port #12552

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e12727a
Allow HostUrl to remap both address and port
danegsta Oct 30, 2025
133e67d
Fix method signature in test
danegsta Oct 30, 2025
d2d226c
Check correct context value
danegsta Oct 30, 2025
6e3af51
Fix failing tests
danegsta Oct 30, 2025
0803ca5
Remove compatibility suppression that no longer applies
danegsta Oct 30, 2025
f1edd09
Fix more tests
danegsta Oct 30, 2025
1517f10
REmove unused code
danegsta Oct 30, 2025
b5e52aa
Add comments and enable tunnel in yarp playground
danegsta Oct 30, 2025
0a70960
Update test helper to ask for specific endpoint
danegsta Oct 30, 2025
47cb2a3
Ensure allocated endpoint checks still work the same
danegsta Oct 30, 2025
3a3d9fd
Updated method compat
danegsta Oct 30, 2025
93a2e30
Optional method
danegsta Oct 30, 2025
15fcf89
Don't add ambiguous method
danegsta Oct 30, 2025
81575b8
Add additional comments and move config to appsettings
danegsta Oct 31, 2025
9395839
Merge branch 'release/13.0' into backport/pr-12521-to-release/13.0
danegsta Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure allocated endpoint checks still work the same
  • Loading branch information
@danegsta
danegsta authored and github-actions committed Oct 31, 2025
commit 47cb2a3a6154e962693821184eec60835a9ce0a3
2 changes: 1 addition & 1 deletion src/Aspire.Hosting/ApplicationModel/EndpointReference.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public EndpointReferenceExpression Property(EndpointProperty property)

foreach (var nes in endpointAnnotation.AllAllocatedEndpoints)
{
if (StringComparers.NetworkID.Equals(nes.NetworkID, _contextNetworkID))
if (StringComparers.NetworkID.Equals(nes.NetworkID, _contextNetworkID ?? KnownNetworkIdentifiers.LocalhostNetwork))
{
if (!nes.Snapshot.IsValueSet)
{
Expand Down