Skip to content

Conversation

@mitchdenny
Copy link
Member

Fixing up some supply chain warnings on internal builds that are generating warning noise.

Copilot AI review requested due to automatic review settings November 1, 2025 10:26
@mitchdenny mitchdenny self-assigned this Nov 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12592

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12592"

@mitchdenny mitchdenny added the area-engineering-systems infrastructure helix infra engineering repo stuff label Nov 1, 2025
@mitchdenny mitchdenny requested a review from radical November 1, 2025 10:26
@mitchdenny mitchdenny added this to the 13.0 milestone Nov 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Docker base images in the WithDockerfile playground application from community images to Microsoft-provided container images for better security and support.

  • Updated Go builder image from golang:1.22-alpine to mcr.microsoft.com/oss/go/microsoft/golang:1.23
  • Updated runtime base image from alpine:latest to mcr.microsoft.com/cbl-mariner/base/core:2.0
  • Changes applied consistently across both sync and async dynamic Dockerfile generation examples
Comments suppressed due to low confidence (1)

playground/withdockerfile/WithDockerfile.AppHost/Program.cs:11

  • The default Go version parameter is still set to '1.22', but the dynamic Dockerfile generators now use golang:1.23. Consider updating this parameter default to '1.23' to maintain consistency across the codebase.
var goVersion = builder.AddParameter("goversion", "1.22");

@mitchdenny mitchdenny merged commit b48094c into main Nov 1, 2025
296 checks passed
@mitchdenny mitchdenny deleted the fix-golang-image-warnings branch November 1, 2025 19:31
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 13.0, 13.1 Nov 1, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants