-
Notifications
You must be signed in to change notification settings - Fork 771
Fix .env files being overwritten by Docker Compose publisher #12656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a61b138
Initial plan
Copilot 65b1889
Fix EnvFile to preserve user-modified values when saving keys only
Copilot bd3a719
Refactor EnvFile to store path and use internal Entries property
Copilot eb5371f
Add logging when overwriting existing env files and fix whitespace
Copilot 2df4bf4
Add tests for env file overwrite logging and fix PrepareAsync
Copilot 4df01ff
Remove unused SharedEnvFile property
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix EnvFile to preserve user-modified values when saving keys only
When SaveKeysOnly is called, it now checks if keys already exist on disk with non-empty values and preserves those values instead of overwriting them. This ensures that user modifications to .env files are not lost during subsequent publish operations. Co-authored-by: captainsafia <[email protected]>
- Loading branch information
commit 65b1889b922b007884f5b54735400fefe62b835a
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...DockerComposePublisherTests.DockerComposeAppendsNewKeysToEnvFileOnPublish#01.verified.env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # Parameter param1 | ||
| PARAM1= | ||
| PARAM1=changed | ||
|
|
||
| # Parameter param2 | ||
| PARAM2= | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...DockerComposePublisherTests.DockerComposeDoesNotOverwriteEnvFileOnPublish#01.verified.env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| # Parameter param1 | ||
| PARAM1= | ||
| PARAM1=changed | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace on line 134. The blank line before
lines.Add(string.Empty);contains only whitespace characters, which violates coding standards. Remove the trailing whitespace.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in eb5371f.