Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 11, 2025

Description

Fixes #12858

Caused by regression in FluentUI - microsoft/fluentui-blazor#4095

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI review requested due to automatic review settings November 11, 2025 08:41
@github-actions
Copy link
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12886

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12886"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a workaround for a FluentUI bug that causes errors when displaying dialogs on component load. The fix adds a 2-second delay before starting to watch for interactions, allowing FluentUI's JavaScript to initialize properly.

Key changes:

  • Added a Task.Delay(TimeSpan.FromSeconds(2)) before WatchInteractionsAsync() in InteractionsProvider initialization
  • Included explanatory comments and a TODO referencing the upstream FluentUI issue #4311

Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@JamesNK JamesNK merged commit d27bba2 into main Nov 17, 2025
588 of 592 checks passed
@JamesNK JamesNK deleted the jamesnk/interaction-provider-workaround branch November 17, 2025 02:20
@dotnet-policy-service dotnet-policy-service bot added this to the 13.1 milestone Nov 17, 2025
@JamesNK
Copy link
Member Author

JamesNK commented Nov 17, 2025

/backport to release/13.0

@github-actions
Copy link
Contributor

Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19416349924

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refreshing the browser after showing a notification makes the notification disappear

3 participants