-
Notifications
You must be signed in to change notification settings - Fork 763
Workaround bug in interaction provider when displaying dialogs on load #12886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12886Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12886" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a workaround for a FluentUI bug that causes errors when displaying dialogs on component load. The fix adds a 2-second delay before starting to watch for interactions, allowing FluentUI's JavaScript to initialize properly.
Key changes:
- Added a
Task.Delay(TimeSpan.FromSeconds(2))beforeWatchInteractionsAsync()in InteractionsProvider initialization - Included explanatory comments and a TODO referencing the upstream FluentUI issue #4311
davidfowl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢
|
/backport to release/13.0 |
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19416349924 |
Description
Fixes #12858
Caused by regression in FluentUI - microsoft/fluentui-blazor#4095
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate