-
Notifications
You must be signed in to change notification settings - Fork 769
Improve summary details view / toolbars / navbar experience on desktop for low-vision users, as well as mobile users #4245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adamint
merged 58 commits into
dotnet:main
from
adamint:feature/mobile-navigation-layout
Jul 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
ceadb62
Temporarily add nuget.org feed
1aafbe6
Refactor current layout into DesktopLayout component
872e748
wip prototype
8ff306b
Merge branch 'refs/heads/main' into feature/mobile-navigation-layout
f03d884
add mobile nav menu
427a3b8
add rest of nav menu to mobile, increase reconnection modal size on m…
fe7b327
Add common page layout, use it for Resources
b99bfa3
Convert Console Logs toolbar
caf0203
Use new layout for structured logs
82f73a3
fix scroll bars, place toolbar on mobile within footer
cfaed4b
Rename page sections, make title section more generic, do trace detai…
7f33bd1
use new layout for metrics page
c7363b0
Merge branch 'refs/heads/main' into feature/mobile-navigation-layout
7d24ec5
Add context parameter to details views, make them full page height on…
1ec9602
wip custom browser resize logic
047fd78
Get initial viewport parameters for render (do not use scoped js beca…
21bf76a
fix nested h1, increase mobile toolbar button size, add resize listener
4d71eb6
clean up views
699a9b9
remove extra class
2ce07f0
remove redundant code, clean up
a555a12
remove redundant code, add a few comments
7d3bbdf
fix accidental logic bug
5707fff
Increase mobile toolbar height, make entire page scrollable at very l…
29c5bb4
Add translation, comment
6d54c04
move comment
4be7ed8
remove redundant if
8174a54
Move toolbar mobile button to top
c59c0ac
remove padding bottom for page header on mobile
4a87ab3
some requested changes
f7e35c8
try to avoid closing dialog on mobile if a toolbar setting has been c…
173df8d
Persist filter into URL, as well as visible types for resources.
adamint 67430f0
Remove unnecessary button on detail view, invoke listeners after filt…
adamint a5845f0
Move MobileLayout and DesktopLayout logic into MainLayout so that pag…
adamint 84802f6
Open aspire repo link in new tab on mobile navigation
adamint c1122f9
Add divs around page content layout to fix scoped css not being applied
adamint bb2b06c
fix extra div not taking up total height
adamint 60e420e
fix metric scrollbar, change debounced resize event to throttled
adamint c8d06e2
Fix scrollbar erroneously appearing on console logs
6dfd531
Consolidate two selects into one
ce7f7eb
Refactor mobile nav menu to its own component, rename desktop nav men…
cade93f
Show icon as active in mobile navigation menu for the current page
1d8fc56
Close mobile filter/nav menus when changing to desktop layout
44fadbd
Use --accent-foreground-active for active page in mobile nav
387824b
Make detail view close button background transparent in mobile
3930ab2
hide duration progress circle on traces mobile
b6437b5
fix continuous scroll on traces/console logs/structured logs
677991a
add console log application to mobile toolbar
f14ae9c
re-add mobile filter footer button
7b6d725
Merge branch 'refs/heads/main' into feature/mobile-navigation-layout
f4ca506
fix incorrect merge conflicts
a6f3e9a
Merge branch 'refs/heads/main' into feature/mobile-navigation-layout
fe400f1
Avoid invoking redundant SetStateAndNavigateAsync calls, cleanup
1829ec0
fix chart/table state being lost on layout change
309500c
fix toolbar with newline appearance on mobile
e0498a7
Merge branch 'refs/heads/main' into feature/mobile-navigation-layout
aa2bc84
add file headers, fix merge
5ba86a9
fix console logs not updating after layout change
60f7ec2
Merge branch 'refs/heads/main' into feature/mobile-navigation-layout
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
move comment
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.