Skip to content

close #2636: added json schemas for Aspire.Hosting.AppHost and Aspire.Hosting.Azure #4912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 6 commits into from
Aug 26, 2024
Merged

close #2636: added json schemas for Aspire.Hosting.AppHost and Aspire.Hosting.Azure #4912

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b32b679
fix: added appsettings intellisence to show Parameters json property
Jul 15, 2024
9c0cb89
feat: added Aspire Hosting Azure json schema
Jul 15, 2024
8d8e1e4
fixed PR comments
Jul 17, 2024
2873b02
fixed intendence
Jul 17, 2024
ca5ec7e
Merge remote-tracking branch 'upstream/main' into hosting-json-schema…
eerhardt Aug 26, 2024
2fb9228
PR feedback
eerhardt Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: added appsettings intellisence to show Parameters json property
  • Loading branch information
Your Name committed Jul 15, 2024
commit b32b679544631c7c74860fd1436aa5956e892d8a
2 changes: 1 addition & 1 deletion src/Aspire.Hosting.AppHost/Aspire.Hosting.AppHost.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</PropertyGroup>

<ItemGroup>
<None Include="**/*.props;**/*.targets" Pack="true" PackagePath="%(RecursiveDir)%(Filename)%(Extension)" />
<None Include="**/*.props;**/*.targets;*.json" Pack="true" PackagePath="%(RecursiveDir)%(Filename)%(Extension)" />
Copy link
Member

@eerhardt eerhardt Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<None Include="**/*.props;**/*.targets;*.json" Pack="true" PackagePath="%(RecursiveDir)%(Filename)%(Extension)" />
<None Include="**/*.props;**/*.targets" Pack="true" PackagePath="%(RecursiveDir)%(Filename)%(Extension)" />
<None Include="AspireAppHostConfiguration.json" Pack="true" />

Maybe we should just pack the one file we want, that way we don't accidently start including other .json files we don't intend to put in the nupkg.

Copy link
Contributor Author

@vladimir-shirmanov vladimir-shirmanov Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, fixed it

</ItemGroup>

<ItemGroup>
Expand Down
8 changes: 8 additions & 0 deletions src/Aspire.Hosting.AppHost/AspireAppHostConfiguration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "object",
"properties": {
"Parameters": {
"type": "object"
}
}
}
5 changes: 5 additions & 0 deletions src/Aspire.Hosting.AppHost/build/Aspire.Hosting.AppHost.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
<ProjectCapability Include="Aspire" Condition=" '$(IsAspireHost)' == 'true' " />
</ItemGroup>

<ItemGroup>
<JsonSchemaSegment Include="$(MSBuildThisFileDirectory)..\AspireAppHostConfiguration.json"
FilePathPattern="appsettings\..*json" />
</ItemGroup>

<Target Name="_CreateAspireProjectResources">

<ItemGroup>
Expand Down