Skip to content

Use digest for sqlserver and fix tests #5059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joperezr wants to merge 2 commits into from
Closed

Use digest for sqlserver and fix tests #5059

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb4e31
Use digest for sqlserver and fix tests
joperezr Jul 24, 2024
57b3c9b
Fix unit tests
joperezr Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix unit tests
  • Loading branch information
@joperezr
joperezr committed Jul 24, 2024
commit 57b3c9ba8229f5af1fc233915a5b6981f55c7902
2 changes: 1 addition & 1 deletion src/Aspire.Hosting.SqlServer/SqlServerContainerImageTags.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ internal static class SqlServerContainerImageTags
public const string Registry = "mcr.microsoft.com";
public const string Image = "mssql/server";
// Tracking tag: 2022-latest. NOTE: latest digest fails the tests. We need to investigate.
public const string Digest = "sha256:c4369c38385eba011c10906dc8892425831275bb035d5ce69656da8e29de50d8";
public const string Digest = "c4369c38385eba011c10906dc8892425831275bb035d5ce69656da8e29de50d8";
}
2 changes: 1 addition & 1 deletion tests/Aspire.Hosting.Tests/ManifestGenerationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ public void VerifyTestProgramFullManifest()
"sqlserver": {
"type": "container.v0",
"connectionString": "Server={sqlserver.bindings.tcp.host},{sqlserver.bindings.tcp.port};User ID=sa;Password={sqlserver-password.value};TrustServerCertificate=true",
"image": "{{SqlServerContainerImageTags.Registry}}/{{SqlServerContainerImageTags.Image}}@{{SqlServerContainerImageTags.Digest}}",
"image": "{{SqlServerContainerImageTags.Registry}}/{{SqlServerContainerImageTags.Image}}@sha256:{{SqlServerContainerImageTags.Digest}}",
"env": {
"ACCEPT_EULA": "Y",
"MSSQL_SA_PASSWORD": "{sqlserver-password.value}"
Expand Down
4 changes: 2 additions & 2 deletions tests/Aspire.Hosting.Tests/SqlServer/AddSqlServerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public async Task VerifyManifest()
{
"type": "container.v0",
"connectionString": "Server={sqlserver.bindings.tcp.host},{sqlserver.bindings.tcp.port};User ID=sa;Password={sqlserver-password.value};TrustServerCertificate=true",
"image": "{{SqlServerContainerImageTags.Registry}}/{{SqlServerContainerImageTags.Image}}@{{SqlServerContainerImageTags.Digest}}",
"image": "{{SqlServerContainerImageTags.Registry}}/{{SqlServerContainerImageTags.Image}}@sha256:{{SqlServerContainerImageTags.Digest}}",
"env": {
"ACCEPT_EULA": "Y",
"MSSQL_SA_PASSWORD": "{sqlserver-password.value}"
Expand Down Expand Up @@ -175,7 +175,7 @@ public async Task VerifyManifestWithPasswordParameter()
{
"type": "container.v0",
"connectionString": "Server={sqlserver.bindings.tcp.host},{sqlserver.bindings.tcp.port};User ID=sa;Password={pass.value};TrustServerCertificate=true",
"image": "{{SqlServerContainerImageTags.Registry}}/{{SqlServerContainerImageTags.Image}}@{{SqlServerContainerImageTags.Digest}}",
"image": "{{SqlServerContainerImageTags.Registry}}/{{SqlServerContainerImageTags.Image}}@sha256:{{SqlServerContainerImageTags.Digest}}",
"env": {
"ACCEPT_EULA": "Y",
"MSSQL_SA_PASSWORD": "{pass.value}"
Expand Down
2 changes: 1 addition & 1 deletion tests/Aspire.Microsoft.Data.SqlClient.Tests/SqlServerContainerFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public async Task InitializeAsync()
if (RequiresDockerAttribute.IsSupported)
{
Container = new MsSqlBuilder()
.WithImage($"{SqlServerContainerImageTags.Registry}/{SqlServerContainerImageTags.Image}@{SqlServerContainerImageTags.Digest}")
.WithImage($"{SqlServerContainerImageTags.Registry}/{SqlServerContainerImageTags.Image}@sha256:{SqlServerContainerImageTags.Digest}")
.Build();
await Container.StartAsync();
}
Expand Down