Skip to content

WaitFor/WaitForCompletion implementation. #5394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchdenny merged 12 commits into from
Aug 30, 2024
Merged

WaitFor/WaitForCompletion implementation. #5394

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9ae6a64
WaitFor/WaitForCompletion implementation.
mitchdenny Aug 23, 2024
a42780b
Better XML doc comments.
mitchdenny Aug 23, 2024
cb52d52
Update src/Aspire.Hosting/ResourceBuilderExtensions.cs
mitchdenny Aug 23, 2024
a88cd1f
Add test cases.
mitchdenny Aug 23, 2024
bf58bb8
WaitForCompletion
mitchdenny Aug 27, 2024
a80d501
Add more tests.
mitchdenny Aug 28, 2024
c969099
Test tweaks and PR feedback.
mitchdenny Aug 28, 2024
ab6668f
PR feedback. Make WaitFor cause a failure if the process exists or fa…
mitchdenny Aug 28, 2024
d1d57ad
Tweaks to logging and using nginx container image instead.
mitchdenny Aug 29, 2024
735eba9
Remove WaitFor from TestShop to validate that it isn't the problem.
mitchdenny Aug 29, 2024
ab5a3fa
Merge branch 'main' into mitchdenny/wait-for
mitchdenny Aug 30, 2024
79150b0
Skip Kafka test.
mitchdenny Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/Aspire.Hosting/ResourceBuilderExtensions.cs 
Co-authored-by: David Fowler <[email protected]>
  • Loading branch information
@mitchdenny @davidfowl
mitchdenny and davidfowl authored Aug 23, 2024
commit cb52d52f2d2c4e52134788cf29e65bafd47b90c3
2 changes: 1 addition & 1 deletion src/Aspire.Hosting/ResourceBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ public static IResourceBuilder<T> WaitFor<T>(this IResourceBuilder<T> builder, I
{
var rls = e.Services.GetRequiredService<ResourceLoggerService>();
var resourceLogger = rls.GetLogger(builder.Resource);
resourceLogger.LogInformation($"Waiting for resource '{dependency.Resource.Name}' to enter the '{KnownResourceStates.Running}' state.");
resourceLogger.LogInformation("Waiting for resource '{Name}' to enter the '{State}' state.", dependency.Resource.Name, KnownResourceStates.Running);

var rns = e.Services.GetRequiredService<ResourceNotificationService>();
await rns.PublishUpdateAsync(builder.Resource, s => s with { State = KnownResourceStates.Waiting }).ConfigureAwait(false);
Expand Down