Skip to content

[tests] Add more playground apps #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radical merged 8 commits into from
Aug 27, 2024
Merged

[tests] Add more playground apps #5395

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a9e392e
[tests] Add WithDockerfile playground app test
radical Aug 23, 2024
0bdbfeb
[tests] Add Kakfa playground app to tests
radical Aug 23, 2024
736b871
WithDockerfile playground app: Set DOCKER_BUILDKIT=1
radical Aug 23, 2024
5e9602e
WatchNotifications: Cancel, or set exception on tcs when WatchAsync f…
radical Aug 23, 2024
a7cb8ce
LoggerNotificationExtensions: Add WaitForAllTestAsync
radical Aug 23, 2024
7162617
Use the new method from LoggerNotificationExtensions
radical Aug 23, 2024
f861204
fix build
radical Aug 23, 2024
c1ce916
Fix test
radical Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WithDockerfile playground app: Set DOCKER_BUILDKIT=1
  • Loading branch information
@radical
radical committed Aug 23, 2024
commit 736b871f1ef2ed966088a849f9504ba8c4c0fd3c
3 changes: 2 additions & 1 deletion playground/withdockerfile/WithDockerfile.AppHost/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@

builder.AddDockerfile("mycontainer", "qots")
.WithBuildArg("GO_VERSION", goVersion)
.WithBuildSecret("SECRET_ASENV", secret);
.WithBuildSecret("SECRET_ASENV", secret)
.WithEnvironment("DOCKER_BUILDKIT", "1");
Copy link
Member

@mitchdenny mitchdenny Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this here or in the MSBuild file.

Copy link
Member Author

@radical radical Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set it here to have it close to where it is needed.

Copy link
Member

@eerhardt eerhardt Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have it in both places?

Copy link
Member Author

@radical radical Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is set for tests running on the build machine (note to self: can be dropped now), and for basictests on helix.


#if !SKIP_DASHBOARD_REFERENCE
// This project is only added in playground projects to support development/debugging
Expand Down