Skip to content

Logging ordering fixes and feedback #5398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesNK merged 4 commits into from
Aug 27, 2024
Merged

Logging ordering fixes and feedback #5398

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5cf820d
WIP
JamesNK Aug 22, 2024
9ef1a6e
PR feedback
JamesNK Aug 27, 2024
db0ec0a
Update
JamesNK Aug 27, 2024
a089e52
Comment
JamesNK Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Comment
  • Loading branch information
@JamesNK
JamesNK committed Aug 27, 2024
commit a089e5265a3ebbcec88286dba9ee9aa590db61bb
1 change: 1 addition & 0 deletions src/Aspire.Hosting/ApplicationModel/ResourceLoggerService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ public async IAsyncEnumerable<IReadOnlyList<LogLine>> WatchAsync([EnumeratorCanc

using var _ = _logStreamCts.Token.Register(() => channel.Writer.TryComplete());

// No need to lock in the log method because TryWrite/TryComplete are already threadsafe.
void Log(LogEntry log) => channel.Writer.TryWrite(log);

LogEntry[] backlogSnapshot;
Expand Down