Skip to content

Initial integration of codespace URL rewriting logic into hosting. #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchdenny merged 6 commits into from
Oct 25, 2024
Merged

Initial integration of codespace URL rewriting logic into hosting. #6183

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee584c7
Initial integration of codespace URL rewriting logic into hosting.
mitchdenny Oct 8, 2024
8a8b879
Add unit tests.
mitchdenny Oct 8, 2024
5901dd8
Update src/Aspire.Hosting/Codespaces/CodespacesUrlRewriter.cs
mitchdenny Oct 8, 2024
f580e60
PR feedback.
mitchdenny Oct 8, 2024
54fee06
Share config acquisition logic/exceptions.
mitchdenny Oct 8, 2024
5f406e9
Update src/Aspire.Hosting/Codespaces/CodespacesUrlRewriter.cs
mitchdenny Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/Aspire.Hosting/Codespaces/CodespacesUrlRewriter.cs 
Co-authored-by: James Newton-King <[email protected]>
  • Loading branch information
@mitchdenny @JamesNK
mitchdenny and JamesNK authored Oct 9, 2024
commit 5f406e9745f355ae7de0e25beab667f96173f132
2 changes: 1 addition & 1 deletion src/Aspire.Hosting/Codespaces/CodespacesUrlRewriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace Aspire.Hosting.Codespaces;

internal class CodespacesUrlRewriter(ILogger<CodespacesUrlRewriter> logger, IConfiguration configuration, ResourceNotificationService resourceNotificationService) : BackgroundService
internal sealed class CodespacesUrlRewriter(ILogger<CodespacesUrlRewriter> logger, IConfiguration configuration, ResourceNotificationService resourceNotificationService) : BackgroundService
{
private const string CodespacesEnvironmentVariable = "CODESPACES";
private const string CodespaceNameEnvironmentVariable = "CODESPACE_NAME";
Expand Down