Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
43ac440
Make resource HealthStatus computed from HealthReports
Oct 18, 2024
8b3406a
change HealthStatus back to property, fix test
Oct 18, 2024
c608065
Update HealthStatus when state changes
Oct 18, 2024
d8556f4
Return null HealthStatus when not running, use constant
Oct 18, 2024
8f605c9
add 16 to reserved fields
Oct 18, 2024
d4d6849
add default argument to _healthReports, re-add property
Oct 18, 2024
5955d5f
Say resource is unhealthy if it is running but a health check has not…
Oct 18, 2024
a29cc72
Change Health State -> Health state
Oct 18, 2024
e817af7
Remove redundant condition
Oct 18, 2024
20dd730
clean up
Oct 18, 2024
b864dad
add test for ComputeHealthStatus
Oct 18, 2024
1c0c161
Disambiguate have not received health reports and empty health reports
Oct 18, 2024
0e9aa7e
Revert change, add health reports to test PublishUpdate to reflect ac…
Oct 18, 2024
908ad8d
Set health reports to [] on resources that don't have health checks
Oct 18, 2024
b151230
Merge branch 'main' into dev/adamint/remove-aggregated-healthstatus
Oct 18, 2024
5d2d053
test disabling all rhc tests
Oct 19, 2024
4c5858e
Merge branch 'main' into dev/adamint/remove-aggregated-healthstatus
Oct 19, 2024
f6dd57c
try enabling 4 tests
Oct 19, 2024
3050ff8
enable additional 3 tests
Oct 19, 2024
94ee0cc
re-skip 2 checks
Oct 19, 2024
aeb4618
add initial health snapshots in resource notification service
Oct 19, 2024
b696e47
Fix playground.
mitchdenny Oct 20, 2024
85ac554
set health report on publish
Oct 21, 2024
50c92d9
run CI again
Oct 21, 2024
6f96288
re-add additional test
Oct 21, 2024
4a3f64d
re-enable additional test
Oct 21, 2024
e937b92
re-enable last test
Oct 21, 2024
55b5629
remove the redundant parentheses
Oct 21, 2024
b352068
remove duplicate logic
Oct 21, 2024
6056a29
clean up
Oct 21, 2024
3199d76
remove unnecessary newlines
Oct 21, 2024
b3ecfeb
remove HealthAnnotationsInitialized
Oct 21, 2024
c38a5ff
add comment
Oct 22, 2024
2bb8e07
re-add health status computation in dashboard
Oct 22, 2024
feb1dc7
forgot newline
Oct 22, 2024
5145c38
fix test
Oct 22, 2024
b88279a
Add a healthy check resources in to health check sandbox to showcase …
Oct 22, 2024
5b91f84
Update resource health reports if any have changed after the health c…
Oct 22, 2024
69abad0
move logic into above condition
Oct 22, 2024
f7127eb
extract to local static method
Oct 22, 2024
0129991
use string comparers
Oct 22, 2024
8a02eb5
return true if health check name is not found in existing health reports
Oct 22, 2024
2799a2a
Merge branch 'main' into dev/adamint/remove-aggregated-healthstatus
Oct 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test disabling all rhc tests
  • Loading branch information
Adam Ratzman committed Oct 19, 2024
commit 5d2d053d9ab8aa662f72016f86f19b824fabe440
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace Aspire.Hosting.Tests.Health;

public class ResourceHealthCheckServiceTests(ITestOutputHelper testOutputHelper)
{
[Fact]
[Fact(Skip = "Test")]
public async Task ResourcesWithoutHealthCheck_HealthyWhenRunning()
{
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);
Expand Down Expand Up @@ -42,7 +42,7 @@ await rns.PublishUpdateAsync(resource.Resource, s => s with
await app.StopAsync();
}

[Fact]
[Fact(Skip = "Test")]
public async Task ResourcesWithHealthCheck_NotHealthyUntilCheckSucceeds()
{
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);
Expand Down Expand Up @@ -78,7 +78,7 @@ await rns.PublishUpdateAsync(resource.Resource, s => s with
await app.StopAsync();
}

[Fact]
[Fact(Skip = "Test")]
[ActiveIssue("https://github.com/dotnet/aspire/issues/6363")]
public async Task HealthCheckIntervalSlowsAfterSteadyHealthyState()
{
Expand Down Expand Up @@ -124,7 +124,7 @@ await rns.PublishUpdateAsync(resource.Resource, s => s with
await app.StopAsync(abortTokenSource.Token);
}

[Fact]
[Fact(Skip = "Test")]
public async Task HealthCheckIntervalDoesNotSlowBeforeSteadyHealthyState()
{
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);
Expand Down Expand Up @@ -171,7 +171,7 @@ await rns.PublishUpdateAsync(resource.Resource, s => s with
await app.StopAsync(abortTokenSource.Token);
}

[Fact]
[Fact(Skip = "Test")]
public async Task ResourcesWithoutHealthCheckAnnotationsGetReadyEventFired()
{
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);
Expand Down Expand Up @@ -200,7 +200,7 @@ await rns.PublishUpdateAsync(resource.Resource, s => s with
await app.StopAsync();
}

[Fact]
[Fact(Skip = "Test")]
public async Task PoorlyImplementedHealthChecksDontCauseMonitoringLoopToCrashout()
{
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);
Expand Down Expand Up @@ -239,7 +239,7 @@ await rns.PublishUpdateAsync(resource.Resource, s => s with
await app.StopAsync();
}

[Fact]
[Fact(Skip = "Test")]
public async Task ResourceHealthCheckServiceDoesNotRunHealthChecksUnlessResourceIsRunning()
{
using var builder = TestDistributedApplicationBuilder.CreateWithTestContainerRegistry(testOutputHelper);
Expand Down Expand Up @@ -304,7 +304,7 @@ await rns.PublishUpdateAsync(parent.Resource, s => s with
await app.StopAsync();
}

[Fact]
[Fact(Skip = "Test")]
public async Task ResourceHealthCheckServiceOnlyRaisesResourceReadyOnce()
{
using var builder = TestDistributedApplicationBuilder.CreateWithTestContainerRegistry(testOutputHelper);
Expand Down Expand Up @@ -363,7 +363,7 @@ await rns.PublishUpdateAsync(parent.Resource, s => s with
await app.StopAsync();
}

[Fact]
[Fact(Skip = "Test")]
public async Task VerifyThatChildResourceWillBecomeHealthyOnceParentBecomesHealthy()
{
using var builder = TestDistributedApplicationBuilder.CreateWithTestContainerRegistry(testOutputHelper);
Expand Down